[JSPWIKI-649] CachingProvider.deleteVersion leaves a stale m_historyCache

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.3, 2.8.4
• Fix Version/s: 2.8.3
• Component/s: Core & storage

Environment

Ubuntu, Sun Java 1.6

• Assignee: Unassigned
• Reporter: Magnus Lindberg
• Created: 05/May/10 08:12
• Updated: 11/Sep/11 02:50
• Resolved: 08/May/10 16:19

Description

Hi JSPWiki developers,

The function
public void deleteVersion( String pageName, int version )
in class CachingProvider does not always update the page history cache appropriately.
As a result, NoSuchVersionException:s can be thrown, if it's later assumed that a page exists,
because it's present in the (cached) history list.

Below patch should fix the bug. (Works for me.)

Regards, Magnus

<pre>
Index: src/com/ecyrd/jspwiki/providers/CachingProvider.java
===================================================================
— src/com/ecyrd/jspwiki/providers/CachingProvider.java (revision 938415)
+++ src/com/ecyrd/jspwiki/providers/CachingProvider.java (working copy)
@@ -815,10 +815,10 @@

{ m_cache.removeEntry( pageName ); m_textCache.removeEntry( pageName ); - m_historyCache.removeEntry( pageName ); }

m_provider.deleteVersion( pageName, version );
+ m_historyCache.removeEntry( pageName );
}
}
</pre>