[JSPWIKI-612] There is a small bug in the ...\JSPWiki\templates\default\admin\UserManagement.jsp

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.3
• Fix Version/s: 2.8.4, 3.0
• Component/s: Templates and UI

Environment

windows XP,IE6,IE7

• Assignee: Unassigned
• Reporter: 高法正
• Created: 19/Nov/09 11:59
• Updated: 15/Nov/21 13:49
• Resolved: 21/Nov/09 14:13

Description

In the UserManagement.jsp page,there is a select box like that:

<select name="userid" id="userid" size="16" onchange="javascript:refreshUserInfo()">
<c:forEach var="user" items="${engine.userManager.userDatabase.wikiNames}">
<option><c:out value="${user.name}" escapeXml="true"/></option>
</c:forEach>
</select>
and the is a javascript function, it want to get the value of the select box. The function like that:
function refreshUserInfo()
{
var userid = $('userid').getValue();

if( userid == '-New-' ) return;

Wiki.jsonrpc("users.getUserInfo", [userid], function(userprofile)

{ $('loginname').value = userprofile.loginName; $('loginid').value = userprofile.loginName; $('fullname').value = userprofile.fullname; $('email').value = userprofile.email; $('lastmodified').setHTML(constructdate(userprofile.lastModified)); $('creationdate').setHTML(constructdate(userprofile.created)); }

);
}
In the option tag of the select box,there is not "value" attribute,so the code "$('userid').getValue()" get a empty String,
then it will occur a js bug.

But in the firefox3.5,the bug will not happen.

Chage the select box like that:
<select name="userid" id="userid" size="16" onchange="javascript:refreshUserInfo()">
<c:forEach var="user" items="${engine.userManager.userDatabase.wikiNames}">
<option value="${user.name}"><c:out value="${user.name}" escapeXml="true"/></option>
</c:forEach>
</select>
the bug gone.