Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Graduating
    • Fix Version/s: Graduating, 3.0, 2.9
    • Component/s: None
    • Labels:
      None

      Description

      To quote ASF Board resolution from May 2004: http://mail-archives.apache.org/mod_mbox/jakarta-jmeter-dev/200402.mbox/%3C4039F65E.7020406@atg.com%3E

      • In conjunction with the the discussion about relicensing and some
        copyright issues, the Board is establishing an official policy in this
        area:
      • each and every file must have exactly one Copyright line, specifying
        The Apache Software Foundation. additional individual or corporate
        copyrights are not allowed.

      (of course, binary files or certain restrictively formatted files
      cannot include the copyright and license, but the copyright/license
      header should be in everything possible)

      • for contributions of entire files/packages, it is permissible to
        include a section saying something along the lines of "originally
        written by ...". this text should occur after the copyright and
        license header.
      • author tags are officially discouraged. these create difficulties in
        establishing the proper ownership and the protection of our
        committers. there are other social issues dealing with collaborative
        development, but the Board is concerned about the legal ramifications
        around the use of author tags
      • it is quite acceptable and encouraged to recognize developers' efforts
        in a CHANGES file, or some other descriptive file which is associated
        with the overall PMC or release rather than individual files.

        Activity

        Hide
        Florian Holeczek added a comment -

        Closing this, since 2.9 has been released

        Show
        Florian Holeczek added a comment - Closing this, since 2.9 has been released
        Hide
        Harry Metske added a comment -

        Fixed in 2.9.0-svn-1

        Show
        Harry Metske added a comment - Fixed in 2.9.0-svn-1
        Hide
        Harry Metske added a comment -

        not completely fixed in 2.8 (which is now graduation candidate)

        Show
        Harry Metske added a comment - not completely fixed in 2.8 (which is now graduation candidate)
        Hide
        Harry Metske added a comment -

        Fixed in 3.0.0-svn-146

        Show
        Harry Metske added a comment - Fixed in 3.0.0-svn-146
        Hide
        Harry Metske added a comment -

        While creating the patch for this I stumbled upon org.apache.wiki.api.ModuleData which also has an author field in it, I think we should remove that too, any objections ?

        The commit will touch more than 200 files, any objections against doing it tonight or tomorrow ?

        Show
        Harry Metske added a comment - While creating the patch for this I stumbled upon org.apache.wiki.api.ModuleData which also has an author field in it, I think we should remove that too, any objections ? The commit will touch more than 200 files, any objections against doing it tonight or tomorrow ?
        Hide
        Craig L Russell added a comment -

        Hi Murray,

        I think everyone knows that you are not included in the list of those considered as not contributing. There are 27 names on the list, and eight (by my count) current contributors, yourself included.

        I think it's appropriate for the authors to be attributed, but the @author tags just are not a good way to do it.

        The @author tags are available in the svn history for those folks who want to find authorship for some obscure piece of code. But I'd guess that a question posed to jspwiki-dev will get an answer quicker than an individual post to the original author (wherever the author might be presently).

        But it is considered a "barrier to entry" for prospective patch writers who see an author tag and think that they are not worthy of patching work by that author.

        Craig

        Show
        Craig L Russell added a comment - Hi Murray, I think everyone knows that you are not included in the list of those considered as not contributing. There are 27 names on the list, and eight (by my count) current contributors, yourself included. I think it's appropriate for the authors to be attributed, but the @author tags just are not a good way to do it. The @author tags are available in the svn history for those folks who want to find authorship for some obscure piece of code. But I'd guess that a question posed to jspwiki-dev will get an answer quicker than an individual post to the original author (wherever the author might be presently). But it is considered a "barrier to entry" for prospective patch writers who see an author tag and think that they are not worthy of patching work by that author. Craig
        Hide
        Murray Altheim added a comment -

        Andrew, I tend to agree that ASF's policy is unfortunate. The issue of credit is mitigated somewhat by inclusion in the NOTICE or README file, but that does eliminate the connection between name and class, whatever its pros and cons. To know that a certain person was the original designer of a complicated component is valuable information, no matter how many people have subsequently touched that code, and I suppose with my library hat on I tend to object to the destruction of information.

        Earlier I'd sent a message to Janne regarding this and I include a relevant portion here:

        > [...]
        > If I am included in the list of those considered as not contributing
        > to the code base (which has for many months been the case), you
        > might understand that the time and energy I spend on contributing to
        > open source projects is not my own to determine, and has of late been
        > focused on a number of other projects, with our current use of JSPWiki
        > in a maintenance mode. We're also waiting until the newer 3.0 platform
        > stabilises before considering further work. I'm not in a position to
        > contribute my personal time to the project as I'm time-wise fully
        > committed.
        >
        > All of the above said, this project has my explicit permission to
        > remove any existing tags containing my name.

        Murray

        Show
        Murray Altheim added a comment - Andrew, I tend to agree that ASF's policy is unfortunate. The issue of credit is mitigated somewhat by inclusion in the NOTICE or README file, but that does eliminate the connection between name and class, whatever its pros and cons. To know that a certain person was the original designer of a complicated component is valuable information, no matter how many people have subsequently touched that code, and I suppose with my library hat on I tend to object to the destruction of information. Earlier I'd sent a message to Janne regarding this and I include a relevant portion here: > [...] > If I am included in the list of those considered as not contributing > to the code base (which has for many months been the case), you > might understand that the time and energy I spend on contributing to > open source projects is not my own to determine, and has of late been > focused on a number of other projects, with our current use of JSPWiki > in a maintenance mode. We're also waiting until the newer 3.0 platform > stabilises before considering further work. I'm not in a position to > contribute my personal time to the project as I'm time-wise fully > committed. > > All of the above said, this project has my explicit permission to > remove any existing tags containing my name. Murray
        Show
        Janne Jalkanen added a comment - And a great video on the topic: http://video.google.com/videoplay?docid=-4216011961522818645&ei=8o0YSbiFOY6qrgLC2PnLDQ&q=poisonous+people
        Hide
        Janne Jalkanen added a comment -

        Here's an explanation from the then-president of ASF of the policy. To me it makes sense.

        http://marc.info/?l=xml-cocoon-dev&m=107788069123268&w=2

        Show
        Janne Jalkanen added a comment - Here's an explanation from the then-president of ASF of the policy. To me it makes sense. http://marc.info/?l=xml-cocoon-dev&m=107788069123268&w=2
        Hide
        Andrew Jaquith added a comment -

        I feel that the Apache policy is unfortunate, but I understand the rationale. If the presence of @author tags is a barrier to graduation, then we can't have them. So we should remove them all. As Janne said, we can give contributors credit in the README.

        Show
        Andrew Jaquith added a comment - I feel that the Apache policy is unfortunate, but I understand the rationale. If the presence of @author tags is a barrier to graduation, then we can't have them. So we should remove them all. As Janne said, we can give contributors credit in the README.
        Hide
        Janne Jalkanen added a comment -

        It was pointed out that these names should go to README, not deleted altogether. We still want to celebrate the contributors!

        Show
        Janne Jalkanen added a comment - It was pointed out that these names should go to README, not deleted altogether. We still want to celebrate the contributors!
        Hide
        Janne Jalkanen added a comment -

        Well, most of those people don't contribute to the codebase anymore... And we've got ICLAs from them, so we can go ahead and modify their code at will.

        Show
        Janne Jalkanen added a comment - Well, most of those people don't contribute to the codebase anymore... And we've got ICLAs from them, so we can go ahead and modify their code at will.
        Hide
        Harry Metske added a comment -

        Now, I personally don't care much about having my author tags in source files, but I remember some people have.
        Is this still an issue ?

        Can we just remove them :

        metskem@gneisenau ~/workspace/JSPWiki $ find . -name '*.java' -type f -exec grep '@author' {} \; | wc -l
        228
        metskem@gneisenau ~/workspace/JSPWiki $ find . -name '*.java' -type f -exec grep '@author' {} \; |awk '

        { print $2 $3 $4 }

        '|sort -u
        @author<ahref="mailto:hps@intermeta.de">Henning
        @authorAndrewJaquith
        @authorAndrewR.
        @authorArent-JanBanck
        @authorChristophSauer
        @authorChuckSmith
        @authorCraigR.
        @authorDanFrankowski
        @authorDavidAu
        @authorDirkFrederickx
        @authorebu
        @authorebuat
        @authorErikBunn
        @authorFlorianHoleczek
        @authorHannoEichelberger
        @authorHarryMetske
        @authorJanneJalkanen
        @authorJohnVolkar
        @authorKeesKuip
        @authorKenLiu
        @authorMurrayAltheim
        @authorScottHulbert
        @authorScottHurlbert
        @authorSebastianBaltes
        @authorSteffenSchramm
        @authorTorstenHildebrandt.
        @authorWoutervan

        Show
        Harry Metske added a comment - Now, I personally don't care much about having my author tags in source files, but I remember some people have. Is this still an issue ? Can we just remove them : metskem@gneisenau ~/workspace/JSPWiki $ find . -name '*.java' -type f -exec grep '@author' {} \; | wc -l 228 metskem@gneisenau ~/workspace/JSPWiki $ find . -name '*.java' -type f -exec grep '@author' {} \; |awk ' { print $2 $3 $4 } '|sort -u @author<ahref="mailto:hps@intermeta.de">Henning @authorAndrewJaquith @authorAndrewR. @authorArent-JanBanck @authorChristophSauer @authorChuckSmith @authorCraigR. @authorDanFrankowski @authorDavidAu @authorDirkFrederickx @authorebu @authorebuat @authorErikBunn @authorFlorianHoleczek @authorHannoEichelberger @authorHarryMetske @authorJanneJalkanen @authorJohnVolkar @authorKeesKuip @authorKenLiu @authorMurrayAltheim @authorScottHulbert @authorScottHurlbert @authorSebastianBaltes @authorSteffenSchramm @authorTorstenHildebrandt. @authorWoutervan

          People

          • Assignee:
            Harry Metske
            Reporter:
            Janne Jalkanen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development