JSPWiki
  1. JSPWiki
  2. JSPWIKI-407

Unlocalized messages and times in user, group and attachment management

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8.1
    • Component/s: Localization
    • Labels:
      None

      Description

      1 - On the "Attach" tab of any page, if you click on the "Upload" button, the English error message "Empty file name given.", whatever the language you have selected in your Prefs.

      2 - In the "View Group" tab of the page "User Preferences", the dates in the lines "Created on Tue Jan 08 10:50:49 CET 2008 by 127.0.0.1" and "Last modified on Tue Jan 08 10:50:49 CET 2008 by 127.0.0.1" do not apply the time format set in the "Preferences" tab of the same page.

      3 - In the "View Group" tab of the page "Admin" whose URL is "Group.jsp?group=Admin", the dates in the lines "127.0.0.1 saved this group on Tue Jan 08 10:50:49 CET 2008" and "127.0.0.1 created it on Tue Jan 08 10:50:49 CET 2008. " do not apply the time format set in the "Preferences" tab of the "User Preferences" page.

      4 - The whole text of the page "Forbidden", which is displayed when the user has no right to do what he/she's trying to, and whose URL is "Login.jsp?redirect=Main", is in English, whatever the language Prefs.

      5 - The ListLocksPlugin (used in the SystemInfo page) is not localized at all.

      6 - The value of the variable $loginstatus displayed in the SystemInfo page is not localized.

      1. src_wikipages_it.zip
        23 kB
        Luca Gilardoni
      2. Contrib_JSPWiki281_it.zip
        14 kB
        Luca Gilardoni
      3. JSPWIKI-407_de.patch
        1 kB
        florian1978
      4. JSPWiki-407A.patch
        13 kB
        Harry Metske

        Activity

        Hide
        Harry Metske added a comment -

        Applied Hubert's zh_CN translations to both 2.8.1-svn-16 and 3.0.0-svn-11.

        Show
        Harry Metske added a comment - Applied Hubert's zh_CN translations to both 2.8.1-svn-16 and 3.0.0-svn-11.
        Hide
        Janne Jalkanen added a comment -

        Italian added in 2.8.1-svn-13.

        I have not received any comment from David Gao. Anyone speaking Chinese willing to update the localization?

        Show
        Janne Jalkanen added a comment - Italian added in 2.8.1-svn-13. I have not received any comment from David Gao. Anyone speaking Chinese willing to update the localization?
        Hide
        Janne Jalkanen added a comment -

        Harry, could you put them also in the 2.8 branch?

        Show
        Janne Jalkanen added a comment - Harry, could you put them also in the 2.8 branch?
        Hide
        Harry Metske added a comment -

        Fixed in 3.0.0-svn-7, thanks Luca !

        Show
        Harry Metske added a comment - Fixed in 3.0.0-svn-7, thanks Luca !
        Hide
        Luca Gilardoni added a comment -

        Added core resources (/etc) for _it. Included revised entries for 2.8.1 and a few minor revision on existent material.
        Also added (src_wikipages_it.zip) a translation in Italian of src pages.

        Show
        Luca Gilardoni added a comment - Added core resources (/etc) for _it. Included revised entries for 2.8.1 and a few minor revision on existent material. Also added (src_wikipages_it.zip) a translation in Italian of src pages.
        Hide
        Janne Jalkanen added a comment -

        I've requested translations from David and Luca via email, since it appears they don't follow this issue tracker

        Show
        Janne Jalkanen added a comment - I've requested translations from David and Luca via email, since it appears they don't follow this issue tracker
        Hide
        Harry Metske added a comment -

        DE applied in trunk.

        Now we still need the patch for the IT and zh_CN languages....

        Show
        Harry Metske added a comment - DE applied in trunk. Now we still need the patch for the IT and zh_CN languages....
        Hide
        florian1978 added a comment -

        The DE patch needs to be applied to the trunk, too...
        If this isn't possible, let me know, then I'll create a separate patch.

        Show
        florian1978 added a comment - The DE patch needs to be applied to the trunk, too... If this isn't possible, let me know, then I'll create a separate patch.
        Hide
        Olivier Descout added a comment -

        The French files already include the messages for #1, #5 and #6 (see JSPWIKI-416).

        Show
        Olivier Descout added a comment - The French files already include the messages for #1, #5 and #6 (see JSPWIKI-416 ).
        Hide
        Juan Pablo Santos Rodríguez added a comment -

        done!

        regards,
        jp

        Show
        Juan Pablo Santos Rodríguez added a comment - done! regards, jp
        Hide
        Janne Jalkanen added a comment -

        Can you please update es translation also in 2.8 branch?

        Show
        Janne Jalkanen added a comment - Can you please update es translation also in 2.8 branch?
        Hide
        Juan Pablo Santos Rodríguez added a comment -

        updated es translation in trunk

        regards,
        juanpablo

        Show
        Juan Pablo Santos Rodríguez added a comment - updated es translation in trunk regards, juanpablo
        Hide
        Harry Metske added a comment -

        patched, thanks Florian.

        Show
        Harry Metske added a comment - patched, thanks Florian.
        Hide
        Janne Jalkanen added a comment -

        Ah, ok. Well, it's a good thing this one is already reopened .

        Show
        Janne Jalkanen added a comment - Ah, ok. Well, it's a good thing this one is already reopened .
        Hide
        florian1978 added a comment -

        Hi folks,

        regarding #5 of the original post's list: "The ListLocksPlugin (used in the SystemInfo page) is not localized at all."

        Localization of the two timestamps is still pending in svn-7.

        Regards
        Florian

        Show
        florian1978 added a comment - Hi folks, regarding #5 of the original post's list: "The ListLocksPlugin (used in the SystemInfo page) is not localized at all." Localization of the two timestamps is still pending in svn-7. Regards Florian
        Hide
        florian1978 added a comment -

        DE localization patch

        Show
        florian1978 added a comment - DE localization patch
        Hide
        Harry Metske added a comment -

        awaiting other translations.................tum tum tum tum

        Show
        Harry Metske added a comment - awaiting other translations.................tum tum tum tum
        Hide
        Janne Jalkanen added a comment -

        fi is also updated. Should we reopen this until de, es and zh are updated?

        Show
        Janne Jalkanen added a comment - fi is also updated. Should we reopen this until de, es and zh are updated?
        Hide
        Harry Metske added a comment -

        Fixed in 2.8.1-svn-4
        Also fixed the bug where the group created was showed twice instead of group created and group lastModified.
        The Forbidden.html was not fixed however, we should take this in 3.0 I think.

        nl and en languages are complete, the other languages not (yet).

        Show
        Harry Metske added a comment - Fixed in 2.8.1-svn-4 Also fixed the bug where the group created was showed twice instead of group created and group lastModified. The Forbidden.html was not fixed however, we should take this in 3.0 I think. nl and en languages are complete, the other languages not (yet).
        Hide
        Janne Jalkanen added a comment -

        With the simple modification of throwing with a message key instead of the actual text, I think this should go to 2.8.1.

        Show
        Janne Jalkanen added a comment - With the simple modification of throwing with a message key instead of the actual text, I think this should go to 2.8.1.
        Hide
        Janne Jalkanen added a comment -

        We could use the simple technique that storeAttachment() returns the key, not the actual text. The exception needs to be caught and rethrown (which is a kludge), but I think it'll be fine.

        With Stripes this problem should mostly go away (since there will always be a localization context available), so I think we can just hack this.

        Show
        Janne Jalkanen added a comment - We could use the simple technique that storeAttachment() returns the key, not the actual text. The exception needs to be caught and rethrown (which is a kludge), but I think it'll be fine. With Stripes this problem should mostly go away (since there will always be a localization context available), so I think we can just hack this.
        Hide
        Harry Metske added a comment -

        Partly fixed, but I like some peer review first:

        1.
        I have a modification for it (see attached patch), but I like some peer review first.
        We need the wikicontext to get the ResourceBundle for doing the translation, however the AttachmentManager.storeAttachment() does not pass the wikicontext.
        I could change this, but it requires quite a few more method signature changes, not sure what the best solution is here.

        2&3.
        Patched in GroupContent.jsp and GroupTab.jsp

        4.
        The text is in (the only) html file and it is static content, and it is also an error-page referenced from web.xml .
        To localize this message we should replace the html by a jsp, is that the proper approach ?

        5.
        patched in ListLocksPlugin

        6.
        patched in VariableManager, but with some notes, see patch

        And something completely different: www.jspwiki.org is not responding for 25 minutes now.

        Show
        Harry Metske added a comment - Partly fixed, but I like some peer review first: 1. I have a modification for it (see attached patch), but I like some peer review first. We need the wikicontext to get the ResourceBundle for doing the translation, however the AttachmentManager.storeAttachment() does not pass the wikicontext. I could change this, but it requires quite a few more method signature changes, not sure what the best solution is here. 2&3. Patched in GroupContent.jsp and GroupTab.jsp 4. The text is in (the only) html file and it is static content, and it is also an error-page referenced from web.xml . To localize this message we should replace the html by a jsp, is that the proper approach ? 5. patched in ListLocksPlugin 6. patched in VariableManager, but with some notes, see patch And something completely different: www.jspwiki.org is not responding for 25 minutes now.

          People

          • Assignee:
            Harry Metske
            Reporter:
            Olivier Descout
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development