JSPWiki
  1. JSPWiki
  2. JSPWIKI-388

ParamTag loops forever when parent tag is not ParamHandler

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.6.3
    • Fix Version/s: None
    • Component/s: Core & storage
    • Labels:
      None

      Description

      I recently tried to use tag wiki:Param within a wiki:UploadLink tag, and the page immediately hung. It appears that this combination is not supported (ok), but the infinite loop is presumably not intended.

      The problem is with this code in class ParamTag:

      public int doEndTag()

      { Tag t = null; while( (t = getParent()) != null && !(t instanceof ParamHandler) ) ; ... }

      This code is the same in both jspwiki 2.6.3 (which I am using) and current svn trunk.

      This loops endlessly if the parent of the ParamTag is not a ParamHandler, because getParent() returns the same object each time. Maybe t.getParent() was intended? (although that won't work on the first call when t is null).

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Simon Kitching
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development