JSPWiki
  1. JSPWiki
  2. JSPWIKI-351

Incorrect bundles specified in JSPs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 3.0
    • Component/s: Default template
    • Labels:
      None
    • Environment:

      All

      Description

      i18n strings are improperly stored in CoreResources_.properties, when they should have been specified in templates/default_.properties. The comments at the top of CoreResources specifies that messages are for "JSPWiki internal code, the so-called core code." But these JSPs all look up and use message strings from CoreResources:

      • Comment.jsp
      • Install.jsp
      • LostPassword.jsp
      • NewGroup.jsp
      • Rename.jsp

      Example:

      // Weepy tears and hankies all 'round.
      if( wikiSession.isAuthenticated() )

      { response.sendError( HttpServletResponse.SC_FORBIDDEN, rb.getString("login.error.noaccess") ); return; }

      This is clearly a template/JSP-level error message, NOT an internal error. And similar kinds of code are sprinked all over the other JSPs.

      I recommend we consolidate default.properties and CoreResources.properties. The easiest way would simply be to concatenate the files. Then, in WikiContext.getBundle(), any requests for "CoreResources" could be simply diverted to default.properties.

        Activity

        Andrew Jaquith created issue -
        Janne Jalkanen made changes -
        Field Original Value New Value
        Fix Version/s 2.8 [ 12312864 ]
        Fix Version/s 3.0 [ 12312865 ]
        Andrew Jaquith made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Andrew Jaquith
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development