[JSPWIKI-351] Incorrect bundles specified in JSPs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8
• Fix Version/s: 3.0
• Component/s: Templates and UI

Environment

All

• Assignee: Unassigned
• Reporter: Andrew R. Jaquith
• Created: 20/Aug/08 14:49
• Updated: 31/Dec/08 17:13
• Resolved: 31/Dec/08 17:13

Description

i18n strings are improperly stored in CoreResources_.properties, when they should have been specified in templates/default_.properties. The comments at the top of CoreResources specifies that messages are for "JSPWiki internal code, the so-called core code." But these JSPs all look up and use message strings from CoreResources:

• Comment.jsp
• Install.jsp
• LostPassword.jsp
• NewGroup.jsp
• Rename.jsp

Example:

// Weepy tears and hankies all 'round.
if( wikiSession.isAuthenticated() )

{ response.sendError( HttpServletResponse.SC_FORBIDDEN, rb.getString("login.error.noaccess") ); return; }

This is clearly a template/JSP-level error message, NOT an internal error. And similar kinds of code are sprinked all over the other JSPs.

I recommend we consolidate default.properties and CoreResources.properties. The easiest way would simply be to concatenate the files. Then, in WikiContext.getBundle(), any requests for "CoreResources" could be simply diverted to default.properties.