Uploaded image for project: 'JSPWiki'
  1. JSPWiki
  2. JSPWIKI-283

modified WIKIWORD_REGEX in JSPWikiMarkupParser causes a lot JUNIT tests to fail with an NPE

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.7.x
    • 2.7.x
    • Core & storage
    • None
    • Ubuntu Linux 7.04
      JSPWiki 2.7.0-svn-34

    Description

      While running JUNIT tests I notice several 787 errors, the overall success rate drops from 98 % to 26% .
      Digging a little further brings me to a modified JSPWikiMarkupParser. The revision comment says that only String(Buffer) has been replaced by StringBuilder.
      However, I notice another change in the static final String WIKIWORD_REGEX
      new: "(^|<|(http://|https://|mailto([A-Za-z0-9_/\\.\\+\\?\\#\\-
      @=&;~%]+))";
      old: "(^|[[:^alnum:]])([[:upper:]][[:lower:]][[:upper:]][[:alnum:]]*|(http://|https://|mailto([A-Za-z0-9_/\\.\\+\\?\\#\\-
      @=&;~%]+))";

      Reverting this change gives me the old better JUNIT test results again.

      Attachments

        Activity

          People

            Unassigned Unassigned
            metskem Harry Metske
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: