Jetspeed 2
  1. Jetspeed 2
  2. JS2-848

Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance degradation)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.2.0
    • Component/s: Customizer
    • Labels:
      None

      Description

      When I change decorator of some portlet using the customizer, decorator changes without any problem, but name of decorator doesn't displays in decorator combobox of customizer.
      The problem is inside WEB-INF\templates\layout\html\columns\layout.vm.
      Problem is in code (2 times per this file):
      #if (!$f.Decorator)
      #set ($fd = $f.Decorator)
      #end
      You should change first line of this code block to
      #if($f.Decorator).
      Also, there is code block:
      #foreach($pd in $decorationFactory.getPortletDecorations($rc))
      #set ($fd = "")
      #if (!$f.Decorator)
      #set ($fd = $f.Decorator)
      #end
      <option value='$pd' #if ($pd == $fd) SELECTED #end>$pd
      #end
      </select>
      code of setting $fd is inside the cycle, but $fd is never changes inside this cycle. So, there is a good idea to move this setting block before cycle.

      Patch that solves this problem is attached to this JIRA record.

      1. layout_vm.patch
        1 kB
        Vitaly Baranovsky

        Activity

        Hide
        Vivek Kumar added a comment -

        Patch applied Thanks Vitaly Baranovsky

        Show
        Vivek Kumar added a comment - Patch applied Thanks Vitaly Baranovsky

          People

          • Assignee:
            Vivek Kumar
            Reporter:
            Vitaly Baranovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development