[JS2-848] Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance degradation)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.3
• Fix Version/s: 2.2.0
• Component/s: Customizer
• Assignee: Vivek Kumar
• Reporter: Vitaly Baranovsky
• Created: 12/Jan/08 13:10
• Updated: 04/Oct/11 21:08
• Resolved: 14/Oct/08 05:46

Description

When I change decorator of some portlet using the customizer, decorator changes without any problem, but name of decorator doesn't displays in decorator combobox of customizer.
The problem is inside WEB-INF\templates\layout\html\columns\layout.vm.
Problem is in code (2 times per this file):
#if (!$f.Decorator)
#set ($fd = $f.Decorator)
#end
You should change first line of this code block to
#if($f.Decorator).
Also, there is code block:
#foreach($pd in $decorationFactory.getPortletDecorations($rc))
#set ($fd = "")
#if (!$f.Decorator)
#set ($fd = $f.Decorator)
#end
<option value='$pd' #if ($pd == $fd) SELECTED #end>$pd
#end
</select>
code of setting $fd is inside the cycle, but $fd is never changes inside this cycle. So, there is a good idea to move this setting block before cycle.

Patch that solves this problem is attached to this JIRA record.