[JS2-238] Subject object is abandoned after the JAAS authentication

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.2.0
• Component/s: Security, SSO
• Environment: JetSpeed-2.0-M3-dev, JDK1.4.2_07, Windows XP SP2
• Assignee: Ate Douma
• Reporter: Jian Liao
• Created: 23/Apr/05 23:49
• Updated: 04/Oct/11 21:08
• Resolved: 25/Sep/08 22:48

Description

I want to add a customized JAAS LoginModule to implement single sign-on. So I found the JAAS configuration file, login.conf, change it like this:

Jetspeed {
org.apache.jetspeed.security.impl.DefaultLoginModule required debug=true;
com.xxx.xxx.LoginModelImpl optional debug=true;
};

I debug my LoginModuleImpl, everything is ok, I add my principal object and a credential object to the Subject object. But when I want to retrieve them back in the portlet, I just found to principal and credential created by DefaultLoginModule.
Mine disappeared.

So I look through all the source code of J2. I found that the Subject object created by LoginContext is abandoned after the successfully login. The first request after the login will new a Subject object in the SecurityValve, but this subject object is not created by LoginContext, but UserManager. Then put it into session. That is the reason I lost all my own principal and credential.

I think that is not a good idea to create a new subject object after the login. It make JAAS authentication meaningless. Why don't we just put the subject object created by LoginContext into session with the attribute "org.apache.jetspeed.security.subject", right after the login.