Apache Jena
  1. Apache Jena
  2. JENA-410

Reinstate or deprecate user-defined types

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Jena 2.11.2
    • Component/s: Jena
    • Labels:
      None

      Description

      As part of JENA-351 the test file and tests for user-defined XSD types disappeared.

      While these were originally motivated by the DAML+OIL approach to data types, it was also possible to create user-defined XSD datatypes and register them via XSDDatatype.loadUserDefined.

      Should either reinstate the test file and tests (presumably in TestTypedLiterals) or cease support for such user defined types by marking XSDDatatype.loadUserDefined as deprecated and updating documentation at
      http://jena.apache.org/documentation/notes/typed-literals.html

      Preferences?

        Activity

        Hide
        Claude Warren added a comment -

        As far as I know, it is still possible to add user defined types. I do this in the persistence annotation project. I will verify that it still works this evening.

        Show
        Claude Warren added a comment - As far as I know, it is still possible to add user defined types. I do this in the persistence annotation project. I will verify that it still works this evening.
        Hide
        Dave Reynolds added a comment -

        Yes the implementation is still there, it is the test cases that have gone.

        If this means that you use the interface that would presumably argue for reinstating the tests rather than deprecating the functionality.

        Show
        Dave Reynolds added a comment - Yes the implementation is still there, it is the test cases that have gone. If this means that you use the interface that would presumably argue for reinstating the tests rather than deprecating the functionality.
        Hide
        Claude Warren added a comment -

        While looking in the 2.10.1-SNAPSHOT code I find that jena-core/src/test/java/com/hp/hpl/jena/graph/test/TestTypedLiterals.java has a method called testUserDef() that appears to test the functioning of user defined data types. The test suite appears to contain the method. and TestPackage includes it. So I don't understand where this test is missing from. What is the problem with the current testing configuration?

        Show
        Claude Warren added a comment - While looking in the 2.10.1-SNAPSHOT code I find that jena-core/src/test/java/com/hp/hpl/jena/graph/test/TestTypedLiterals.java has a method called testUserDef() that appears to test the functioning of user defined data types. The test suite appears to contain the method. and TestPackage includes it. So I don't understand where this test is missing from. What is the problem with the current testing configuration?
        Hide
        Dave Reynolds added a comment -

        As it says in http://jena.apache.org/documentation/notes/typed-literals.html there are two sorts of user defined data types in Jena. These are unimaginatively called "user defined XSD datatypes" and "user defined non-XSD datatypes". That test covers the latter case. Testing the former case requires parsing of an xsd file, there used to be a test for that which relied on the DAML+OIL file. The key call involved is XSDDatatype.loadUserDefined and Eclipse tells me there's no references to that in the code base and thus no tests.

        Show
        Dave Reynolds added a comment - As it says in http://jena.apache.org/documentation/notes/typed-literals.html there are two sorts of user defined data types in Jena. These are unimaginatively called "user defined XSD datatypes" and "user defined non-XSD datatypes". That test covers the latter case. Testing the former case requires parsing of an xsd file, there used to be a test for that which relied on the DAML+OIL file. The key call involved is XSDDatatype.loadUserDefined and Eclipse tells me there's no references to that in the code base and thus no tests.
        Hide
        Andrew Crapo added a comment -

        Is there any resolution on this? I'd like to use user defined XSD datatypes but it sounds like the implementation with XSDDatatype.loadUserDefined might go away? Is there another approach in the works? If it isn't going away it would be nice to have the example back in the distrib.

        Show
        Andrew Crapo added a comment - Is there any resolution on this? I'd like to use user defined XSD datatypes but it sounds like the implementation with XSDDatatype.loadUserDefined might go away? Is there another approach in the works? If it isn't going away it would be nice to have the example back in the distrib.
        Hide
        Dave Reynolds added a comment -

        It is not resolved ... just fallen into a black hole

        I had forgotten this was assigned to me. I'll try to find time to restore the test files and code.

        Show
        Dave Reynolds added a comment - It is not resolved ... just fallen into a black hole I had forgotten this was assigned to me. I'll try to find time to restore the test files and code.
        Hide
        ASF subversion and git services added a comment -

        Commit 1589060 from der@apache.org in branch 'jena/trunk'
        [ https://svn.apache.org/r1589060 ]

        Reinstating testing of user-defined datatypes to address JENA-410

        Show
        ASF subversion and git services added a comment - Commit 1589060 from der@apache.org in branch 'jena/trunk' [ https://svn.apache.org/r1589060 ] Reinstating testing of user-defined datatypes to address JENA-410
        Hide
        Dave Reynolds added a comment -

        Original test and test file reinstated.

        The test example is based on the early DAML+OIL specification but is not specific to DAML+OIL. Support for user defined XSD datatypes should probably be reviewed at some point, especially in the light of OWL2. However, until any future decision to deprecate it or not, the test remains.

        Show
        Dave Reynolds added a comment - Original test and test file reinstated. The test example is based on the early DAML+OIL specification but is not specific to DAML+OIL. Support for user defined XSD datatypes should probably be reviewed at some point, especially in the light of OWL2. However, until any future decision to deprecate it or not, the test remains.

          People

          • Assignee:
            Dave Reynolds
            Reporter:
            Dave Reynolds
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development