[JENA-2326] recent change to UpdateEngineWorker validation is probably wrong

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Jena 4.5.0
• Fix Version/s: Jena 4.6.0
• Component/s: ARQ
• Assignee: Andy Seaborne
• Reporter: Brian Vosburgh
• Created: 13/May/22 04:33
• Updated: 25/Aug/22 09:43
• Resolved: 14/May/22 10:23

Description

A validation method in UpdateEngineWorker was recently changed. (I think the change is related to JENA-2293.)

The previous method looked like this:

    private boolean validBinaryGraphOp(UpdateBinaryOp update) {
        if ( update.getSrc().isDefault() )
            return true;

        if ( update.getSrc().isOneNamedGraph() ) {
            Node gn = update.getSrc().getGraph();
            if ( !datasetGraph.containsGraph(gn) ) {
                if ( !update.getSilent() )
                    error("No such graph: " + gn);
                return false;
            }
            return true;
        }
        error("Invalid source target for oepration; " + update.getSrc());
        return false;
    }

The current method looks like this:

 

    private void validateBinaryGraphOp(UpdateBinaryOp update) {
        if ( update.getSrc().isDefault() )
            return;
        if ( update.getSrc().isOneNamedGraph() ) {
            Node gn = update.getSrc().getGraph();
            if ( !datasetGraph.containsGraph(gn) )
                throw errorEx("No such graph: " + gn);
        }
        throw errorEx("Invalid source target for operation; " + update.getSrc());
    }
 

Assuming the validation logic has not changed, the current method is inconsistent with the previous version. To remain consistent, it should look like this:

 

    private void validateBinaryGraphOp(UpdateBinaryOp update) {
        if ( update.getSrc().isDefault() )
            return;
        if ( update.getSrc().isOneNamedGraph() ) {
            Node gn = update.getSrc().getGraph();
            if ( !datasetGraph.containsGraph(gn) )
                throw errorEx("No such graph: " + gn);
            return;
        }
        throw errorEx("Invalid source target for operation; " + update.getSrc());
    }
 

Note the second return statement.

This is causing unexpected test failures in our product test suite.

Issue Links

• is related to: JENA-2327 Add the rdf-tests CG maintained SPARQL tests.
• links to: GitHub Pull Request #1304