Apache Jena
  1. Apache Jena
  2. JENA-219

SDB does not pass slice tests on Microsoft SQL Server

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SDB 1.3.5
    • Fix Version/s: SDB 1.3.5
    • Component/s: SDB
    • Labels:
      None
    • Environment:

      Microsoft SQL Server 2008

      Description

      According to [1], SDB supports Microsoft SQL Server. However, when I follow the instructions and run the test suite, all the Slice tests fail with com.hp.hpl.jena.sdb.test.junit.QueryTestSDB: SQLException in executing SQL statement. When I debug further, I see that this is because SQL statements are being executed with LIMIT and OFFSET keywords, which are not supported by Microsoft SQL Server (OFFSET is coming in SQL Server 2012, though). I checked the code and I'm not sure how this would have ever worked with Microsoft SQL Server.

      [1] http://incubator.apache.org/jena/documentation/sdb/databases_supported.html

        Activity

        Hide
        Mark Roth added a comment -

        I have a patch that fixes this issue - will post once the patch is cleaned up.

        Show
        Mark Roth added a comment - I have a patch that fixes this issue - will post once the patch is cleaned up.
        Hide
        Rob Vesse added a comment -

        Ok, I have both SQL Server 2005 and 2008 so will test and verify once you post the patch

        Show
        Rob Vesse added a comment - Ok, I have both SQL Server 2005 and 2008 so will test and verify once you post the patch
        Hide
        Mark Roth added a comment -

        This patch resolves this issue - all manifest tests pass. Please confirm.

        Show
        Mark Roth added a comment - This patch resolves this issue - all manifest tests pass. Please confirm.
        Hide
        Rob Vesse added a comment -

        Will test and confirm later this week

        Show
        Rob Vesse added a comment - Will test and confirm later this week
        Hide
        Rob Vesse added a comment -

        What environment did you run the tests in?

        I got the patches applied fine but I have been unable to test so far because our corporate network is so locked down I can't access the SQL Server instances on my local VM (we run OS X as our main OS) or on the remote servers to which I have access.

        This means I will probably not get to test till the weekend when I have time to test at home and can freely expose my SQL Server instances

        Show
        Rob Vesse added a comment - What environment did you run the tests in? I got the patches applied fine but I have been unable to test so far because our corporate network is so locked down I can't access the SQL Server instances on my local VM (we run OS X as our main OS) or on the remote servers to which I have access. This means I will probably not get to test till the weekend when I have time to test at home and can freely expose my SQL Server instances
        Hide
        Rob Vesse added a comment -

        Verified and applied, will leave this open for a couple of days in case this impacts anybody using other databases (which it shouldn't AFAICT)

        Show
        Rob Vesse added a comment - Verified and applied, will leave this open for a couple of days in case this impacts anybody using other databases (which it shouldn't AFAICT)
        Hide
        Rob Vesse added a comment -

        Patch was applied a couple of days ago as previously commented

        Show
        Rob Vesse added a comment - Patch was applied a couple of days ago as previously commented
        Hide
        Mark Roth added a comment -

        Excellent! Thanks!

        Show
        Mark Roth added a comment - Excellent! Thanks!

          People

          • Assignee:
            Rob Vesse
            Reporter:
            Mark Roth
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development