Uploaded image for project: 'Commons Jelly'
  1. Commons Jelly
  2. JELLY-85

TagScript doesn't clear its cached tags after run()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-beta-4
    • Fix Version/s: 1.0-RC2
    • Component/s: core / taglib.core
    • Labels:
      None

      Description

      TagScript caches the tags it generates in a ThreadLocal. At the beginning of run() it checks to see if the context wants to cache tags - if not, it clears the cache and regenerates it.

      But there is no corresponding check and cache clearing at the end of run(). So if a tag holds onto some significant resource, that resource will hang around until the thread goes away or until the tag is run again.

      I am using Jelly Swing extensively, and various tags end up attached to the AWT Event thread for the lifetime of my application.

      As a quick fix, I have a patch that simply repeats the check-and-clear-cache behavior at the end of TagScript.run(). I also have a patch that adds this behavior to StaticTagScript, whose run() never seems to clear cached tags.

      I am probably just unclear, but it seems to me that there is a deeper issue as well - the context is being asked whether it wants to cache tags, but the result of this question affects the TagScript, which is really independent of the context. It seems like if context wants to cache tags, perhaps the ThreadLocal used for their storage ought to belong to the context somehow.

        Attachments

        1. ASF.LICENSE.NOT.GRANTED--StaticTagScript_patch.txt
          0.8 kB
          Scott Howlett
        2. ASF.LICENSE.NOT.GRANTED--TagScript_patch.txt
          0.5 kB
          Scott Howlett
        3. includeAndDefineExample.zip
          0.6 kB
          Paul Libbrecht

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jshowlett Scott Howlett
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: