[JELLY-77] [patch] Update jelly:util replace tag to replace entire strings

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0-beta-4
• Component/s: taglib.util

Environment

win xp, jdk1.3.1

• Assignee: Unassigned
• Reporter: Paul O'Fallon
• Created: 24/Aug/03 21:25
• Updated: 31/Aug/04 09:20
• Resolved: 31/Aug/04 09:20

Description

The replace tag documentation indicates that it replaces "occurrances of strings", but the code only replaces instances of the first character in the old string with the first character in the new string. It also does not accept an empty string as the new string. I have a patch that updates the replace tag to replace whole strings, as well as accept empty strings, available here:
http://home.earthlink.net/~ofallon/patches/jelly-util-diff.txt
it updates both the code and the project.xml file to add a dependency on commons-lang. All of the existing util tag tests still passed after making this change.

If this change is implemented, it may also make sense to change the attributes "oldChar" and "newChar" to just "old" and "new", but I'll leave decision that up to someone else

Thanks,
Paul