Commons Jelly
  1. Commons Jelly
  2. JELLY-285

Overridding the expression parser only works in some circumstances, not all

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.0.1
    • Component/s: core / taglib.core
    • Labels:
      None

      Description

      The TagLibrary class allows derived classes to override the expression parser to select something other than JEXL; however, this is not used consistently. For example, this is not used when parsing text, and is not used when static tags.

      Attached is a patch script which fixes the problem, plus some accompanying unit tests and testing tag library.

      1. JELLY-285.patch.txt
        18 kB
        John Spackman
      2. JELLY-285.patch-v2.txt
        18 kB
        John Spackman

        Issue Links

          Activity

          Hide
          John Spackman added a comment -

          Patch script

          Show
          John Spackman added a comment - Patch script
          Hide
          Paul Libbrecht added a comment -

          John,

          i am a bit concerned by:

          • protected void configureTagScript(TagScript aTagScript) {
            + protected void configureTagScript(TagLibrary tagLibrary, TagScript aTagScript) {

          which really seems to mean that you change the API.
          Even though it sounds like an unusual place to use, there may be things out there that use this method.
          Could duplicate that method with a method that finds the tag-script?

          paul

          Show
          Paul Libbrecht added a comment - John, i am a bit concerned by: protected void configureTagScript(TagScript aTagScript) { + protected void configureTagScript(TagLibrary tagLibrary, TagScript aTagScript) { which really seems to mean that you change the API. Even though it sounds like an unusual place to use, there may be things out there that use this method. Could duplicate that method with a method that finds the tag-script? paul
          Hide
          John Spackman added a comment -

          Updated in line with Paul's comments

          Show
          John Spackman added a comment - Updated in line with Paul's comments

            People

            • Assignee:
              Paul Libbrecht
              Reporter:
              John Spackman
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development