Commons Jelly
  1. Commons Jelly
  2. JELLY-229

Add list of possible completions to jelly-tags-interaction

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Component/s: taglib.interaction
    • Labels:
      None
    • Environment:

      Linux FC3, jdk-14.2_10, Maven-1.1-beta-3-SNAPSHOT

      Description

      This is a follow-up of JELLY-175. I added a method setCompletor(list) allowing to set a list of strings that is used by jline for tab completion. Use it like: <i:ask completor="$

      {list}

      " answer="a"/>. The list of tab-completion strings is added to the history list, ie new goals typed in console mode will always be tab-completed afterwards.

      Please note that I have bumped the jline dependency to the latest 0.9.5. This is not on ibiblio yet, I have created an upload request ( http://jira.codehaus.org/browse/MAVENUPLOAD-883 ), if it is not found, you will have to put the jline-0.9.5.jar into your local repo by hand.

      To test it: I have deployed a snapshot of the maven 1 console plugin:

      maven plugin:download -Dmaven.repo.remote=http://www.ibiblio.org/maven,http://cvs.apache.org/repository/ -DgroupId=maven -DartifactId=maven-console-plugin -Dversion=1.2-SNAPSHOT

      The default value for the completor list is "clean,java:compile,jar,test,xdoc,site,quit,help", but you can define your own custom list using the maven.console.completor.goals property.

      1. JELLY-229.patch
        3 kB
        Lukas Theussl

        Activity

        Hide
        Paul Libbrecht added a comment -

        Applying patch and successfully run the described test and the included sample.
        I'd wish for automated tests but this seems impossible for now. So we'll... just... accept by seeing that the sample works.
        paul

        Show
        Paul Libbrecht added a comment - Applying patch and successfully run the described test and the included sample. I'd wish for automated tests but this seems impossible for now. So we'll... just... accept by seeing that the sample works. paul
        Hide
        Lukas Theussl added a comment -

        Thanks Paul!

        What else does it take to get commons-jelly-tags-interaction-1.1 released? Can you give me an ETA? I can't release the console plugin with a snapshot dependency so I'm kind of tied to this now unless I roll back this nice feature. Also, JELLY-175 can be marked resolved as well now?

        (Btw: I don't agree with you calling Einstein 'a physicist before the 20th century', all his major contributions were done after 1905! )

        Show
        Lukas Theussl added a comment - Thanks Paul! What else does it take to get commons-jelly-tags-interaction-1.1 released? Can you give me an ETA? I can't release the console plugin with a snapshot dependency so I'm kind of tied to this now unless I roll back this nice feature. Also, JELLY-175 can be marked resolved as well now? (Btw: I don't agree with you calling Einstein 'a physicist before the 20th century', all his major contributions were done after 1905! )
        Hide
        Paul Libbrecht added a comment -

        Fixed components and versions.

        Show
        Paul Libbrecht added a comment - Fixed components and versions.
        Hide
        Paul Libbrecht added a comment -

        I changed the question to "born before the 20th century" .

        For release to happen is just to get a vote on commons-dev which I opened yesterday and expect to close on Friday 12:00 GMT.
        Is that ok for you ?
        paul

        Show
        Paul Libbrecht added a comment - I changed the question to "born before the 20th century" . For release to happen is just to get a vote on commons-dev which I opened yesterday and expect to close on Friday 12:00 GMT. Is that ok for you ? paul
        Hide
        Lukas Theussl added a comment -

        Fantastic! Thanks so much for your quick response!

        -Lukas

        Show
        Lukas Theussl added a comment - Fantastic! Thanks so much for your quick response! -Lukas

          People

          • Assignee:
            Paul Libbrecht
            Reporter:
            Lukas Theussl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development