Uploaded image for project: 'Commons Jelly'
  1. Commons Jelly
  2. JELLY-150

j:forEach tag not properly using varStatus attribute

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: jface-1.0-beta-1, jface-1.0, swt-1.0, 1.0-beta-4, 1.0-beta-5, 1.0, 1.1-beta-1
    • Fix Version/s: 1.0
    • Component/s: core / taglib.core
    • Labels:
      None
    • Environment:

      win2k / cygwin

      Description

      According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks!

        Attachments

        1. jelly-150-dg.txt
          14 kB
          dion gillard
        2. forEach2.patch
          14 kB
          Ben Anderson
        3. forEach.patch
          9 kB
          Ben Anderson

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              andersonbd1 Ben Anderson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: