Commons Jelly
  1. Commons Jelly
  2. JELLY-133

ComponentTag methods should throw more exceptions

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0-beta-4
    • Component/s: taglib.swing
    • Labels:
      None

      Description

      Many component tag methods don't throw JellyTagException. They should, because child classes might want to do it. This patch adds exceptions to several methods, which could break code that's currently inhereting from ComponentTag in their own code (like me).

      But I think that the time is now for this improvement.

        Activity

        dion gillard made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 1.0-beta-4 [ 10215 ]
        Resolution Fixed [ 1 ]
        Hide
        dion gillard added a comment -

        Applied. I think JellyTagException is the right one too.

        Show
        dion gillard added a comment - Applied. I think JellyTagException is the right one too.
        Hide
        Hans Gilde added a comment -

        And I don't know about JellyException vs JellyTagExcpetion. What do you think? Is one part of the internal interface and one part of the external?

        Show
        Hans Gilde added a comment - And I don't know about JellyException vs JellyTagExcpetion. What do you think? Is one part of the internal interface and one part of the external?
        Hide
        Hans Gilde added a comment -

        ButtonGroup should not have been in there, it requires more files that I submitted under JELLY-132. Should I resubmit this patch w/o button group? I filed this seperately from JELLY-132 for protocol and testability resons only.

        Show
        Hans Gilde added a comment - ButtonGroup should not have been in there, it requires more files that I submitted under JELLY-132 . Should I resubmit this patch w/o button group? I filed this seperately from JELLY-132 for protocol and testability resons only.
        Hide
        dion gillard added a comment -

        I noticed the ButtonGroup class is in there too. Is that intentional?

        Also, should it be JellyTagException, or JellyException?

        Show
        dion gillard added a comment - I noticed the ButtonGroup class is in there too. Is that intentional? Also, should it be JellyTagException, or JellyException?
        Hans Gilde made changes -
        Field Original Value New Value
        Attachment component-tag-add-exception.txt [ 17678 ]
        Hans Gilde created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Hans Gilde
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development