Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0-beta-4
    • Component/s: taglib.swing
    • Labels:
      None

      Description

      We need a set of unit tests for Swing tags!

      1. swing-tags-test2.txt
        8 kB
        Hans Gilde
      2. swing-tags-test.txt
        8 kB
        Hans Gilde

        Activity

        Hide
        Hans Gilde added a comment -

        Not complete by any means but it's a start.

        Show
        Hans Gilde added a comment - Not complete by any means but it's a start.
        Hide
        dion gillard added a comment -

        FWIW, these fail under jdk1.3...

        I'm looking into it.

        Show
        dion gillard added a comment - FWIW, these fail under jdk1.3... I'm looking into it.
        Hide
        Hans Gilde added a comment -

        Ok, one of my tests is wrong. But the GBCTag doesn't work under 1.3 at all.

        Show
        Hans Gilde added a comment - Ok, one of my tests is wrong. But the GBCTag doesn't work under 1.3 at all.
        Hide
        dion gillard added a comment -

        And under 1.4

        Show
        dion gillard added a comment - And under 1.4
        Hide
        Hans Gilde added a comment -

        Here's a fix for one of the tests.

        Show
        Hans Gilde added a comment - Here's a fix for one of the tests.
        Hide
        dion gillard added a comment -

        Which one?

        Could you diff it against the current cvs code? Thanks...

        Show
        dion gillard added a comment - Which one? Could you diff it against the current cvs code? Thanks...
        Hide
        Hans Gilde added a comment -

        Nope, sorry, these files aren't in cvs. I couldn't find an existing Swing unit test in cvs.

        Show
        Hans Gilde added a comment - Nope, sorry, these files aren't in cvs. I couldn't find an existing Swing unit test in cvs.
        Hide
        dion gillard added a comment -

        Where were you looking?

        jelly-tags/swing/src/test/org/apache/commons/jelly/swing

        ?

        Show
        dion gillard added a comment - Where were you looking? jelly-tags/swing/src/test/org/apache/commons/jelly/swing ?
        Hide
        Hans Gilde added a comment -

        Yeah, that package has some demos and tests for tables and converters, but no tests for general functionality. My patch added TestSwingTags and swingTags.jelly.

        Show
        Hans Gilde added a comment - Yeah, that package has some demos and tests for tables and converters, but no tests for general functionality. My patch added TestSwingTags and swingTags.jelly.
        Show
        dion gillard added a comment - I committed them about 15 minutes ago. see http://cvs.apache.org/viewcvs.cgi/jakarta-commons/jelly/jelly-tags/swing/src/test/org/apache/commons/jelly/swing/TestSwingTags.java
        Hide
        Hans Gilde added a comment -

        oops. You've already made the change that I put into the second patch.

        I don't know about JDK 1.4, I'm downloading it now. But testGridBagBasic fails under 1.3 because GBCTag uses String.split, which doesn't exist in 1.3.

        Show
        Hans Gilde added a comment - oops. You've already made the change that I put into the second patch. I don't know about JDK 1.4, I'm downloading it now. But testGridBagBasic fails under 1.3 because GBCTag uses String.split, which doesn't exist in 1.3.
        Hide
        Hans Gilde added a comment -

        fyi, I'm using 1.4.2_05 and it all works. I'll try it with 1.4.0.

        Show
        Hans Gilde added a comment - fyi, I'm using 1.4.2_05 and it all works. I'll try it with 1.4.0.
        Hide
        dion gillard added a comment -

        I fixed the String split issue in case u didn't notice.

        Show
        dion gillard added a comment - I fixed the String split issue in case u didn't notice.
        Hide
        Hans Gilde added a comment -

        My cable modem broke and I'm having trouble getting all the Java versions. Is it still failing under any version? I have 1.3.1 and 1.4.2 and the uncommented tests work fine now.

        Show
        Hans Gilde added a comment - My cable modem broke and I'm having trouble getting all the Java versions. Is it still failing under any version? I have 1.3.1 and 1.4.2 and the uncommented tests work fine now.
        Hide
        dion gillard added a comment -

        They're still broken for me on 1.3.1_07, 1.4.2_03 and it wont compile on 1.5

        Show
        dion gillard added a comment - They're still broken for me on 1.3.1_07, 1.4.2_03 and it wont compile on 1.5
        Hide
        dion gillard added a comment -

        fwiw, I'm running the tests using 'maven clean test' from jelly-tags/swing

        Show
        dion gillard added a comment - fwiw, I'm running the tests using 'maven clean test' from jelly-tags/swing
        Hide
        dion gillard added a comment -

        All working!

        Show
        dion gillard added a comment - All working!

          People

          • Assignee:
            Unassigned
            Reporter:
            Hans Gilde
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development