We need a set of unit tests for Swing tags!
fwiw, I'm running the tests using 'maven clean test' from jelly-tags/swing
They're still broken for me on 1.3.1_07, 1.4.2_03 and it wont compile on 1.5
My cable modem broke and I'm having trouble getting all the Java versions. Is it still failing under any version? I have 1.3.1 and 1.4.2 and the uncommented tests work fine now.
I fixed the String split issue in case u didn't notice.
fyi, I'm using 1.4.2_05 and it all works. I'll try it with 1.4.0.
oops. You've already made the change that I put into the second patch.
I don't know about JDK 1.4, I'm downloading it now. But testGridBagBasic fails under 1.3 because GBCTag uses String.split, which doesn't exist in 1.3.
I committed them about 15 minutes ago. see http://cvs.apache.org/viewcvs.cgi/jakarta-commons/jelly/jelly-tags/swing/src/test/org/apache/commons/jelly/swing/TestSwingTags.java
Yeah, that package has some demos and tests for tables and converters, but no tests for general functionality. My patch added TestSwingTags and swingTags.jelly.
Where were you looking?
Nope, sorry, these files aren't in cvs. I couldn't find an existing Swing unit test in cvs.
Could you diff it against the current cvs code? Thanks...
Here's a fix for one of the tests.
And under 1.4
Ok, one of my tests is wrong. But the GBCTag doesn't work under 1.3 at all.
FWIW, these fail under jdk1.3...
I'm looking into it.
Not complete by any means but it's a start.