Commons Jelly
  1. Commons Jelly
  2. JELLY-122

ComponentTag should clear it's bean reference

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-beta-4
    • Fix Version/s: 1.0-beta-4
    • Component/s: None
    • Labels:
      None

      Description

      The Swing CompoentTag should null-out the reference to its bean after it's done executed. No tags keep a reference to the ComponentTag itself, at most they'll get a reference to the underlying bean.

      At the moment, ComponentTag can cause it's bean to stick around in memory unexpectedly. The Tag instance might be cached by the TagScript for later reuse. If the Tag keeps a reference to it's component, then that component won't be GC'd, even if the component is disposed. And the component itself will never be resued, so there's no point in keeping it around.

        Activity

        Hide
        Hans Gilde added a comment -

        and the patch to fix it

        Show
        Hans Gilde added a comment - and the patch to fix it
        Hide
        dion gillard added a comment -

        Applied

        Show
        dion gillard added a comment - Applied

          People

          • Assignee:
            Unassigned
            Reporter:
            Hans Gilde
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development