Commons Jelly
  1. Commons Jelly
  2. JELLY-10

JellySwing should be strict on the attribue names it uses

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0-beta-5
    • Component/s: taglib.swing
    • Labels:
      None

      Description

      http://marc.theaimsgroup.com/?l=jakarta-commons-user&m=103491984004524&w=2

      Also there is a problem with the introspection code when setting properties on Swing components. e.g. witness the hacks we've had to put into the code...

      http://jakarta.apache.org/commons/sandbox/jelly/xref/org/apache/commons/jelly/tags/swing/ComponentTag.html#301

      We should fix this once and for all. Not sure the problem. Maybe its Swing components break the introspector code; we might just have to try call the setter method directly instead?

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        695d 6h 17m 1 dion gillard 12/Sep/04 16:37
        dion gillard made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 1.0-beta-5 [ 10783 ]
        Status Open [ 1 ] Closed [ 6 ]
        Hide
        dion gillard added a comment -

        In 1.1 of the taglib

        Show
        dion gillard added a comment - In 1.1 of the taglib
        Hans Gilde made changes -
        Attachment swing-properties-improvement.2.txt [ 17686 ]
        Hide
        Hans Gilde added a comment -

        replacement for the original patch except that now, the BeanUtils String->int converter isn't replaced with the DebugGraphicsConverter. DebugGraphicsConverter is meant for only one field in JComponent, not all String->int conversions.

        Show
        Hans Gilde added a comment - replacement for the original patch except that now, the BeanUtils String->int converter isn't replaced with the DebugGraphicsConverter. DebugGraphicsConverter is meant for only one field in JComponent, not all String->int conversions.
        Hans Gilde made changes -
        Hide
        Hans Gilde added a comment -

        unit tests for the previous patch

        Show
        Hans Gilde added a comment - unit tests for the previous patch
        Hans Gilde made changes -
        Field Original Value New Value
        Attachment swing-properties-improvement.txt [ 17682 ]
        Hide
        Hans Gilde added a comment -

        This patch makes a two Swing tag interface changes:

        • Invalid bean properties will now cause the Swing script to fail at runtime.
        • The XML attribute to set the debugGraphicsOptions is now either "debugGraphics" or "debugGraphicsOptions", no longer "debug" or "debugGraphicsOption".
        Show
        Hans Gilde added a comment - This patch makes a two Swing tag interface changes: Invalid bean properties will now cause the Swing script to fail at runtime. The XML attribute to set the debugGraphicsOptions is now either "debugGraphics" or "debugGraphicsOptions", no longer "debug" or "debugGraphicsOption".
        Hide
        dion gillard added a comment -

        This one's yours Hans

        Show
        dion gillard added a comment - This one's yours Hans
        Hide
        Hans Gilde added a comment -

        FYI, I'm close to a patch for this. Is some one else working on it?

        Show
        Hans Gilde added a comment - FYI, I'm close to a patch for this. Is some one else working on it?
        Hide
        Hans Gilde added a comment -

        You may already know, but beanutils wants you to use copyProperty rather than setProperty. It seems that setProperty is meant for some custom use while copyProperty does what you're expecting.

        See the latest JavaDoc for the BeanUtil class: http://jakarta.apache.org/commons/beanutils/apidocs/org/apache/commons/beanutils/BeanUtilsBean.html#setProperty(java.lang.Object, java.lang.String, java.lang.Object)

        Show
        Hans Gilde added a comment - You may already know, but beanutils wants you to use copyProperty rather than setProperty. It seems that setProperty is meant for some custom use while copyProperty does what you're expecting. See the latest JavaDoc for the BeanUtil class: http://jakarta.apache.org/commons/beanutils/apidocs/org/apache/commons/beanutils/BeanUtilsBean.html#setProperty(java.lang.Object , java.lang.String, java.lang.Object)
        Hide
        Hans Gilde added a comment -

        You may already know, but beanutils wants you to use copyProperty rather than setProperty. It seems that setProperty is meant for some custom usewhile copyProperty does what you're expecting.

        See the latest JavaDoc for the BeanUtil class: http://jakarta.apache.org/commons/beanutils/apidocs/org/apache/commons/beanutils/BeanUtilsBean.html#setProperty(java.lang.Object, java.lang.String, java.lang.Object)

        Show
        Hans Gilde added a comment - You may already know, but beanutils wants you to use copyProperty rather than setProperty. It seems that setProperty is meant for some custom usewhile copyProperty does what you're expecting. See the latest JavaDoc for the BeanUtil class: http://jakarta.apache.org/commons/beanutils/apidocs/org/apache/commons/beanutils/BeanUtilsBean.html#setProperty(java.lang.Object , java.lang.String, java.lang.Object)
        Hide
        james strachan added a comment -

        An example of this issue is trying to set

        preferredScrollableViewportSize="300,200"

        on a <table> tag.

        Show
        james strachan added a comment - An example of this issue is trying to set preferredScrollableViewportSize="300,200" on a <table> tag.
        james strachan created issue -

          People

          • Assignee:
            james strachan
            Reporter:
            james strachan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development