[JDO-776] Exception on Query.close()

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: JDO 3.2
• Component/s: api
• Assignee: Unassigned
• Reporter: Steve Springett
• Created: 05/Feb/19 07:11
• Updated: 06/Mar/19 18:15
• Resolved: 06/Mar/19 18:15

Description

The Query interface has an exception thrown on the close() method. This prevents elegant use of try-with-resource and requires more complex cases instead, such as try within try, or try-with-resource with catch. In both cases, the code gets rather ugly when using try-with-resource.

 

The closeAll() method however, does not throw an exception which allows for simpler, more elegant code. Users should be encouraged to use modern language constructs, but in the case of the Query interface, I prefer not to, and use closeAll instead.

 

Propose: Remove the Exception from Query.close(). If an exception is thrown while closing it, ignore it.