JDO
  1. JDO
  2. JDO-411

Attempt to bulk-delete Employee records without nulling foreign key references from InsurancePlan

    Details

      Description

      Multiple test cases attempt to bulk delete instances of Person. However, the Employee subclass of Person might wind up having a non-nullable foreign key reference to Insurance or another Employee (via the "mentor" field). While the defaut Derby TCK schema does not have this constraint, in order to be flexible for other databases that will enforce the foreign key by default, some effort should be made to ensure that there are no relation constraints before the bulk deletes are attempted. This can be done by adding a nullForeignKeyReferences() method that will manually make sure that the relations are nulled. See the attached patch.

      This affects the following tests:

      org.apache.jdo.tck.query.delete.DeletePersistentAll.testNoParametersAPI
      org.apache.jdo.tck.query.delete.DeletePersistentAll.testNoParametersSingleString
      org.apache.jdo.tck.query.delete.DeletePersistentAll.testObjectArrayParametersAPI
      org.apache.jdo.tck.query.delete.DeletePersistentAll.testObjectArrayParametersSingleString
      org.apache.jdo.tck.query.delete.DeletePersistentAll.testMapParametersAPI
      org.apache.jdo.tck.query.delete.DeletePersistentAll.testMapParametersSingleString
      org.apache.jdo.tck.query.delete.DeleteQueryElements.testAPI
      org.apache.jdo.tck.query.delete.DeleteQueryElements.testSingleString

      1. DeletePersistentAll.patch
        2 kB
        Marc Prud'hommeaux
      2. JDO-411.patch
        8 kB
        Michael Bouschen

        Activity

        Hide
        Michael Bouschen added a comment -

        Merged changes from trunk into brach 2.0.1 (see revision 452644).

        Show
        Michael Bouschen added a comment - Merged changes from trunk into brach 2.0.1 (see revision 452644).
        Hide
        Michael Bouschen added a comment -

        Checked in the patch (see revision 443483).

        Show
        Michael Bouschen added a comment - Checked in the patch (see revision 443483).
        Hide
        Craig L Russell added a comment -

        Looks good.

        I think your analysis is correct, and using Insurance as the candidate class solves the relationship management issues.

        Show
        Craig L Russell added a comment - Looks good. I think your analysis is correct, and using Insurance as the candidate class solves the relationship management issues.
        Hide
        Michael Bouschen added a comment -

        I agree these tests need to be changed, because they do not take existing references to the instances to be deleted into account.

        The whole point in adding the delete API to the Query interface is to support instance removal without the need to load these instances before the removal. I think using class Person to test the delete API is not a good idea. As Marc pointed out, it requires nulling relationship fields prior to the removal and this means loading instances into memory. So it might happen that the instances to be deleted are loaded prior to removal which is not the intent of the test case.

        I propose to change the test case and use a class where the database schema does not include any foreign keys referencing the table for the class. In the company model class Insurance is an example for such a class. The attached patch for review implements this proposal.

        Show
        Michael Bouschen added a comment - I agree these tests need to be changed, because they do not take existing references to the instances to be deleted into account. The whole point in adding the delete API to the Query interface is to support instance removal without the need to load these instances before the removal. I think using class Person to test the delete API is not a good idea. As Marc pointed out, it requires nulling relationship fields prior to the removal and this means loading instances into memory. So it might happen that the instances to be deleted are loaded prior to removal which is not the intent of the test case. I propose to change the test case and use a class where the database schema does not include any foreign keys referencing the table for the class. In the company model class Insurance is an example for such a class. The attached patch for review implements this proposal.

          People

          • Assignee:
            Michael Bouschen
            Reporter:
            Marc Prud'hommeaux
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development