Details

    1. JDO-401.patch
      0.6 kB
      Craig L Russell

      Activity

      Hide
      kirsh Ilan Kirsh added a comment -

      In org.apache.jdo.tck.api.instancecallbacks.CallingJdoPreclear:

      When optimistic transaction is used, In the commit in line 127 secondaryObj is expected to be persistent non transactional so it is not expected to be cleared, and jdoPreClear should not be called.

      Show
      kirsh Ilan Kirsh added a comment - In org.apache.jdo.tck.api.instancecallbacks.CallingJdoPreclear: When optimistic transaction is used, In the commit in line 127 secondaryObj is expected to be persistent non transactional so it is not expected to be cleared, and jdoPreClear should not be called.
      Hide
      clr Craig L Russell added a comment -

      Need to resolve these issues for maintenance release 1.

      Show
      clr Craig L Russell added a comment - Need to resolve these issues for maintenance release 1.
      Hide
      clr Craig L Russell added a comment -

      Right. The test was written assuming that the default transaction type was datastore. The test needs to be explicit by setting the transaction type to datastore regardless of the default.

      Show
      clr Craig L Russell added a comment - Right. The test was written assuming that the default transaction type was datastore. The test needs to be explicit by setting the transaction type to datastore regardless of the default.
      Hide
      mbo Michael Bouschen added a comment -

      The patch looks good!

      Show
      mbo Michael Bouschen added a comment - The patch looks good!
      Hide
      clr Craig L Russell added a comment -

      svn commit -m "JDO-401 Set Optimisitic to false to make sure jdoPreClear is called" src/java/org/apache/jdo/tck/api/instancecallbacks/CallingJdoPreclear.java
      Sending src/java/org/apache/jdo/tck/api/instancecallbacks/CallingJdoPreclear.java
      Transmitting file data .
      Committed revision 429837.

      Show
      clr Craig L Russell added a comment - svn commit -m " JDO-401 Set Optimisitic to false to make sure jdoPreClear is called" src/java/org/apache/jdo/tck/api/instancecallbacks/CallingJdoPreclear.java Sending src/java/org/apache/jdo/tck/api/instancecallbacks/CallingJdoPreclear.java Transmitting file data . Committed revision 429837.
      Hide
      mbo Michael Bouschen added a comment -

      I merged the change from the trunk into brach 2.0.1 (see revision 452620).

      Show
      mbo Michael Bouschen added a comment - I merged the change from the trunk into brach 2.0.1 (see revision 452620).

        People

        • Assignee:
          clr Craig L Russell
          Reporter:
          kirsh Ilan Kirsh
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development