JDO
  1. JDO
  2. JDO-369

Completeness test doesn't clean up instances of persistent interfaces

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: JDO 2 rc1
    • Fix Version/s: JDO 2 final (2.0)
    • Component/s: tck
    • Labels:
      None

      Description

      The completeness test registers persistence-capable classes to be deleted at tearDown, but it doesn't register persistence-capable interfaces. So the completeness test for persistent interfaces fails the second time through.

      The suggested fix is for the CompanyModelReader to return persistence-capable interfaces along with persistence-capable classes when called for the list of classes to clean up.

      1. JDO-369.patch
        15 kB
        Michael Bouschen

        Activity

        Craig L Russell created issue -
        Hide
        Michael Bouschen added a comment -

        This issue is related to JDO-327.

        Attached you find a patch JDO-369.patch for review including two changes:

        • Adding discriminator column to the schema and metadata files. This change is provided by Erik; I just removed the index definition for the discriminator column from Erik's proposal.
        • CompletenessTest gets the list of teardown classes from the CompanyFactory used by the CompanyModelReader to create the company model instances.
        Show
        Michael Bouschen added a comment - This issue is related to JDO-327 . Attached you find a patch JDO-369 .patch for review including two changes: Adding discriminator column to the schema and metadata files. This change is provided by Erik; I just removed the index definition for the discriminator column from Erik's proposal. CompletenessTest gets the list of teardown classes from the CompanyFactory used by the CompanyModelReader to create the company model instances.
        Michael Bouschen made changes -
        Field Original Value New Value
        Attachment JDO-369.patch [ 12325574 ]
        Hide
        Craig L Russell added a comment -

        The patch looks good. Assuming that all the tests except for companyPMInterface pass, it's good to be checked in.

        Show
        Craig L Russell added a comment - The patch looks good. Assuming that all the tests except for companyPMInterface pass, it's good to be checked in.
        Hide
        Michael Bouschen added a comment -

        Checked in the patch into the trunk (revision 395567) and the 2.0 branch (revision 395568).

        Show
        Michael Bouschen added a comment - Checked in the patch into the trunk (revision 395567) and the 2.0 branch (revision 395568).
        Michael Bouschen made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Andy Jefferson made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Michael Bouschen
            Reporter:
            Craig L Russell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development