JDO
  1. JDO
  2. JDO-355

Remove extra tables/classes in the sql and orm for mappings 5,6, and 7.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: JDO 2 rc1
    • Fix Version/s: JDO 2 final (2.0)
    • Component/s: tck
    • Labels:
      None

      Description

      I noticed that there is a little mismatch between test case MakePersistent, the .sql files, and the .orm files for mappings 5, 6, 7 wrt. which persistence capable classes are needed:

      • Test case MakePersistent uses pc class PCPoint only.
      • The .sql files create tables PCPoint and PCRect.
      • The .orm files specifiy metadata for pc classes PCPoint, PCPoint2, PCRect, and PrimitiveTypes.

      This holds true for application identity and datastore identity as well.

      1. JDO-355.patch
        18 kB
        Michael Bouschen

        Activity

        Hide
        Michael Bouschen added a comment -

        I checked in the patch.

        Sende tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard5.orm
        Sende tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard6.orm
        Sende tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard7.orm
        Sende tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard5.orm
        Sende tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard6.orm
        Sende tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard7.orm
        Sende tck20\src\sql\derby\applicationidentity\schema5.sql
        Sende tck20\src\sql\derby\applicationidentity\schema6.sql
        Sende tck20\src\sql\derby\applicationidentity\schema7.sql
        Sende tck20\src\sql\derby\datastoreidentity\schema5.sql
        Sende tck20\src\sql\derby\datastoreidentity\schema6.sql
        Sende tck20\src\sql\derby\datastoreidentity\schema7.sql
        ?\195?\156bertrage Daten ............
        Revision 389850 ?\195?\188bertragen.

        Show
        Michael Bouschen added a comment - I checked in the patch. Sende tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard5.orm Sende tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard6.orm Sende tck20\src\orm\applicationidentity\org\apache\jdo\tck\pc\mylib\package-standard7.orm Sende tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard5.orm Sende tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard6.orm Sende tck20\src\orm\datastoreidentity\org\apache\jdo\tck\pc\mylib\package-standard7.orm Sende tck20\src\sql\derby\applicationidentity\schema5.sql Sende tck20\src\sql\derby\applicationidentity\schema6.sql Sende tck20\src\sql\derby\applicationidentity\schema7.sql Sende tck20\src\sql\derby\datastoreidentity\schema5.sql Sende tck20\src\sql\derby\datastoreidentity\schema6.sql Sende tck20\src\sql\derby\datastoreidentity\schema7.sql ?\195?\156bertrage Daten ............ Revision 389850 ?\195?\188bertragen.
        Hide
        Michael Bouschen added a comment -

        The attached patch (JDO-355.patch) removes PCRect from the .sql files and PCPoint2, PCRect, and PrimitiveTypes from .orm files for both applicationidentity and datastoreidentity. I just started maven clean build to make sure that the patch does not break anything.

        Show
        Michael Bouschen added a comment - The attached patch ( JDO-355 .patch) removes PCRect from the .sql files and PCPoint2, PCRect, and PrimitiveTypes from .orm files for both applicationidentity and datastoreidentity. I just started maven clean build to make sure that the patch does not break anything.
        Hide
        Craig L Russell added a comment -

        When the tests were written, I think we didn't know exactly what we were going to test, and made extra classes persistent in order to have some flexibility.

        Now that the tests are complete, it's not clear to me that we will ever extend the test cases so we don't need to keep the extra classes in the sql and orm.

        So it's ok with me to remove the extras.

        Show
        Craig L Russell added a comment - When the tests were written, I think we didn't know exactly what we were going to test, and made extra classes persistent in order to have some flexibility. Now that the tests are complete, it's not clear to me that we will ever extend the test cases so we don't need to keep the extra classes in the sql and orm. So it's ok with me to remove the extras.

          People

          • Assignee:
            Michael Bouschen
            Reporter:
            Michael Watzek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development