Details
Description
I ran the jdkim library through find bugs and found a few things. Some things i thought you might be doing because of backwards compatibility. So here is the quick list.
DKIMVerifier:
records.size() == 0 instead of records.isEmpty()
fields.size() == 0 instead of fields.isEmpty()
use of hashtable (it's deprecated)
bodyHashJobs.size() == 0 instead of bodyHashJobs.isEmpty()
verifiedSignatures.size() == 0 instead of verifiedSignatures.isEmpty()
DKIMCommon:
done = new Integer(0) instead of Integer.valueOf(0) *I noticed you have a comment for this already?
DNSPublicKeyRecordRetriever:
use of StringBuffer instead of StringBuilder
SignatureRecordImpl:
use of StringBuffer instead of StringBuilder
TagValue:
use of StringBuffer instead of StringBuilder