[JDKIM-21] potential issues?

• Type: Question
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.2, 1.0
• Fix Version/s: 0.2
• Component/s: library
• Environment: java version "1.6.0_18" ubuntu 10.04
• Assignee: Stefano Bagnara
• Reporter: Ben Aldrich
• Created: 15/Sep/10 17:19
• Updated: 16/Sep/10 22:28
• Resolved: 15/Sep/10 20:49

Description

I ran the jdkim library through find bugs and found a few things. Some things i thought you might be doing because of backwards compatibility. So here is the quick list.

DKIMVerifier:
records.size() == 0 instead of records.isEmpty()
fields.size() == 0 instead of fields.isEmpty()
use of hashtable (it's deprecated)
bodyHashJobs.size() == 0 instead of bodyHashJobs.isEmpty()
verifiedSignatures.size() == 0 instead of verifiedSignatures.isEmpty()

DKIMCommon:
done = new Integer(0) instead of Integer.valueOf(0) *I noticed you have a comment for this already?

DNSPublicKeyRecordRetriever:
use of StringBuffer instead of StringBuilder

SignatureRecordImpl:
use of StringBuffer instead of StringBuilder

TagValue:
use of StringBuffer instead of StringBuilder