[JCS-21] JCS has inconsistent locking of shared data

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: jcs-1.2.7.9.2
• Assignee: Aaron Smuts
• Reporter: Michael Stevens
• Created: 18/Mar/07 15:31
• Updated: 23/Jul/09 19:14
• Resolved: 19/Mar/07 02:29

Description

I've been looking at the trunk JCS code with findbugs (http://findbugs.sf.net/).

One of the things it does is warn when data is inconsistently synchronized - ie when it is sometimes referenced inside a synchronized block and sometimes not. This is not threadsafe - one thread may read old or inconsistent data.

I've patched all the places findbugs complains about by adding appropriate synchronized() blocks.

I suspect this change may require some discussion