Uploaded image for project: 'Commons JCS'
  1. Commons JCS
  2. JCS-21

JCS has inconsistent locking of shared data

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: jcs-1.2.7.9.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      I've been looking at the trunk JCS code with findbugs (http://findbugs.sf.net/).

      One of the things it does is warn when data is inconsistently synchronized - ie when it is sometimes referenced inside a synchronized block and sometimes not. This is not threadsafe - one thread may read old or inconsistent data.

      I've patched all the places findbugs complains about by adding appropriate synchronized() blocks.

      I suspect this change may require some discussion

        Attachments

        1. locking.diff
          8 kB
          Michael Stevens

          Activity

            People

            • Assignee:
              asmuts Aaron Smuts
              Reporter:
              mstevens Michael Stevens
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: