[JCRVLT-590] Remove finalizer in ZipVaultPackage

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.6.0
• Component/s: vlt
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 11/Jan/22 10:30
• Updated: 02/Mar/22 18:13
• Resolved: 13/Jan/22 14:31

Description

Instead of relying on the finalizer in https://github.com/apache/jackrabbit-filevault/blob/561aaa092d721963f16b860de955e6d1752a350e/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L322-L329, every ZipVaultPackage should be explicitly closed. Finalizer have some issue and are deprecated since Java 9 (https://bugs.openjdk.java.net/browse/JDK-8165641).

Issue Links

• relates to: JCRVLT-589 PackageInstallIT leaves test files in tmp folder
• relates to: JCRVLT-591 Detect unclosed packages and archives
• links to: GitHub Pull Request #197