Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Activity

      Hide
      Jukka Zitting added a comment -

      I merged the changes to trunk/jackrabbit-jcr-rmi (where the latest codebase again resides, I'll need to remove commons/jcr-rmi), and enabled the previously failing ACL tests by some extra trickery in the RepositoryStubImpl class.

      Show
      Jukka Zitting added a comment - I merged the changes to trunk/jackrabbit-jcr-rmi (where the latest codebase again resides, I'll need to remove commons/jcr-rmi), and enabled the previously failing ACL tests by some extra trickery in the RepositoryStubImpl class.
      Hide
      Felix Meschberger added a comment -

      Listing the known test failures in the POM (Rev. 925223) allows for the build to succeed without errors.

      Show
      Felix Meschberger added a comment - Listing the known test failures in the POM (Rev. 925223) allows for the build to succeed without errors.
      Hide
      Felix Meschberger added a comment -

      Implemented remote AccessControlManager along with AccessControlList, AccessControlPolicy, AccessControlEntry, Privilege, Principal, and Group support. Some methods are not implemented, mostly methods to update access control.

      Privilege equals and hashCode methods are implemented based on the Privilege name (getting the name is the only round-trip to the server here).

      Committed in Rev. 925218

      This current implementation passes almost all ConformanceTests run during the build. The failing tests all involve unimplemented access control update methods.

      Failing test record:

      Running org.apache.jackrabbit.rmi.ConformanceTest
      Tests run: 1895, Failures: 0, Errors: 21, Skipped: 0, Time elapsed: 93.757 sec <<< FAILURE!

      Results :

      Tests in error:
      testSetIllegalPolicy(org.apache.jackrabbit.test.api.security.AccessControlPolicyTest)
      testGetAccessControlEntries(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAggregatePrivilege(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAggregatedPrivilegesSeparately(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAbstractPrivilege(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddPrivilegesPresentInEntries(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntryAndSetPolicy(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntryIsTransient(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntryInvalidPrincipal(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntryEmptyPrivilegeArray(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntryInvalidPrivilege(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testRemoveAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testRemoveAddedAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testRemoveAccessControlEntryAndSetPolicy(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testRemoveAccessControlEntryIsTransient(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testRemoveIllegalAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntryTwice(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testAddAccessControlEntryAgain(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testExtendPrivileges(org.apache.jackrabbit.test.api.security.AccessControlListTest)
      testSetInvalidPolicy(org.apache.jackrabbit.test.api.security.RSessionAccessControlPolicyTest)

      Tests run: 1895, Failures: 0, Errors: 21, Skipped: 0

      Show
      Felix Meschberger added a comment - Implemented remote AccessControlManager along with AccessControlList, AccessControlPolicy, AccessControlEntry, Privilege, Principal, and Group support. Some methods are not implemented, mostly methods to update access control. Privilege equals and hashCode methods are implemented based on the Privilege name (getting the name is the only round-trip to the server here). Committed in Rev. 925218 This current implementation passes almost all ConformanceTests run during the build. The failing tests all involve unimplemented access control update methods. Failing test record: Running org.apache.jackrabbit.rmi.ConformanceTest Tests run: 1895, Failures: 0, Errors: 21, Skipped: 0, Time elapsed: 93.757 sec <<< FAILURE! Results : Tests in error: testSetIllegalPolicy(org.apache.jackrabbit.test.api.security.AccessControlPolicyTest) testGetAccessControlEntries(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAggregatePrivilege(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAggregatedPrivilegesSeparately(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAbstractPrivilege(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddPrivilegesPresentInEntries(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntryAndSetPolicy(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntryIsTransient(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntryInvalidPrincipal(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntryEmptyPrivilegeArray(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntryInvalidPrivilege(org.apache.jackrabbit.test.api.security.AccessControlListTest) testRemoveAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest) testRemoveAddedAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest) testRemoveAccessControlEntryAndSetPolicy(org.apache.jackrabbit.test.api.security.AccessControlListTest) testRemoveAccessControlEntryIsTransient(org.apache.jackrabbit.test.api.security.AccessControlListTest) testRemoveIllegalAccessControlEntry(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntryTwice(org.apache.jackrabbit.test.api.security.AccessControlListTest) testAddAccessControlEntryAgain(org.apache.jackrabbit.test.api.security.AccessControlListTest) testExtendPrivileges(org.apache.jackrabbit.test.api.security.AccessControlListTest) testSetInvalidPolicy(org.apache.jackrabbit.test.api.security.RSessionAccessControlPolicyTest) Tests run: 1895, Failures: 0, Errors: 21, Skipped: 0

        People

        • Assignee:
          Felix Meschberger
          Reporter:
          Felix Meschberger
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:

            Development