Uploaded image for project: 'Jackrabbit Content Repository'
  1. Jackrabbit Content Repository
  2. JCR-97

Improve Checkstyle conformance

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This is an ongoing meta-issue for improving the Checkstyle conformance of the Jackrabbit codebase.

      Checkstyle (http://checkstyle.sourceforge.net/) is an automated tool for checking conformance with coding standard and good coding style. A Checkstyle report for Jackrabbit can be generated by running "maven checkstyle".

      Currently the Jackrabbit Checkstyle report contains thousands of trivial problems like unused imports and minor formatting issues. While it would be possible to just remove those checks from the Jackrabbit Checkstyle configuration, it would certainly be better to fix the real issues. After fixing the trivial problems, the Checkstyle reports become much more valuable tools in locating troublesome code and identifying chances for improvement.

      While this issue remains open, you have an open mandate to improve the standards conformance and coding style of the Jackrabbit sources. This mandate applies only to changes that fix problems reported by Checkstyle while making no changes to the external interface or behaviour of the changed code.

      The commit messages of such Checkstyle improvements should be labeled with the Jira key of this issue (JCR-97) to mark the changes as style-only. This way other committers will have easier time reviewing your changes for bugs or other unexpected side-effects.

      If you are not a Jackrabbit committer, but want to help improve the Checkstyle conformance, you can make your changes using sources from anonymous subversion and send your changes as an attachment to this issue. Please see the Javadoc improvement issue JCR-73 for details.

      PS. Blind conformance to style guides is seldom beneficial. Please remember that the goal of this issue is to improve Jackrabbit code, not just the Checkstyle output!

        Attachments

        1. jackrabbit.core.cluster_imports.patch
          21 kB
          Jan Kuzniak
        2. jackrabbit.core.config_imports.patch
          5 kB
          Jan Kuzniak
        3. jackrabbit.core.fs_imports.patch
          8 kB
          Jan Kuzniak
        4. jackrabbit.core.jndi.patch
          28 kB
          Jan Kuzniak
        5. jackrabbit.core.lock.patch
          57 kB
          Jan Kuzniak
        6. jackrabbitAPICheckstylePatch.patch
          2 kB
          Jan Kuzniak
        7. jackrabbitCoreClusterCleanup.patch
          137 kB
          Jan Kuzniak
        8. jackrabbitCoreConfigCleanup.patch
          92 kB
          Jan Kuzniak
        9. jackrabbitCoreFsDbCleanup.patch
          369 kB
          Jan Kuzniak
        10. jackrabbitCoreFsDbCleanup.patch
          98 kB
          Jan Kuzniak
        11. jackrabbitCoreUnnecessaryCodeCleanup.patch
          16 kB
          Jan Kuzniak
        12. stacktraceLost.patch
          6 kB
          Jan Kuzniak

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jukkaz Jukka Zitting
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: