Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: security
    • Labels:
      None
    • Environment:
      Jboss 4.0.5.GA (should work on most any), Jackrabbit 1.1, either JCA or server .WAR deployment
    1. pom.xml
      1 kB
      Darren Hartford
    2. SimpleJbossAccessManager.java
      6 kB
      Darren Hartford

      Activity

      Jukka Zitting made changes -
      Workflow jira [ 12390903 ] no-reopen-closed, patch-avail [ 12469367 ]
      Jukka Zitting made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Jukka Zitting made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Hide
      Jukka Zitting added a comment -

      Committed the contributed access manager in revision 526687.

      I modified the class somewhat, backporting it to Java 1.4 and streamlining some of the logic, but made no functional changes. Note that the fully qualified name of the class is now org.apache.jackrabbit.core.security.SimpleJBossAccessManager (no .jboss package, and JBoss with a capital B).

      It seems that the only JBoss-specific part of the class is the use of the "Roles" principal group. How about generalizing the class so that it uses all the principals associated with the subject and not just the "Roles" principals? I think it would also make sense to use the standard JAAS Permission model instead of the custom rolemapping.properties file for access control.

      Thanks for the contribution!

      Show
      Jukka Zitting added a comment - Committed the contributed access manager in revision 526687. I modified the class somewhat, backporting it to Java 1.4 and streamlining some of the logic, but made no functional changes. Note that the fully qualified name of the class is now org.apache.jackrabbit.core.security.SimpleJBossAccessManager (no .jboss package, and JBoss with a capital B). It seems that the only JBoss-specific part of the class is the use of the "Roles" principal group. How about generalizing the class so that it uses all the principals associated with the subject and not just the "Roles" principals? I think it would also make sense to use the standard JAAS Permission model instead of the custom rolemapping.properties file for access control. Thanks for the contribution!
      Jukka N committed 526687 (1 file)
      Reviews: none

      JCR-650: Included the SimpleJBossAccessManager class contributed by Darren Hartford.

      Jukka Zitting made changes -
      Assignee Jukka Zitting [ jukkaz ]
      Fix Version/s 1.3 [ 12312229 ]
      Affects Version/s 1.1 [ 12310346 ]
      Hide
      Jukka Zitting added a comment -

      Looks good! I'll see if I can include this already in the 1.3 release.

      Show
      Jukka Zitting added a comment - Looks good! I'll see if I can include this already in the 1.3 release.
      Darren Hartford made changes -
      Attachment pom.xml [ 12345931 ]
      Darren Hartford made changes -
      Field Original Value New Value
      Attachment SimpleJbossAccessManager.java [ 12345930 ]
      Darren Hartford created issue -

        People

        • Assignee:
          Jukka Zitting
          Reporter:
          Darren Hartford
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development