[JCR-565] Refactor ObservationManagerFactory

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1
• Component/s: observation
• Assignee: Jukka Zitting
• Reporter: Jukka Zitting
• Created: 11/Sep/06 07:32
• Updated: 13/Oct/06 16:03
• Resolved: 16/Sep/06 12:31

Description

The current o.a.j.core.observation.ObservationManagerFactory class has two main responsibilities:

1) Create new ObservationManagerImpl instances as an observation manager factory
2) Manage event consumers and dispatch events within a workspace

These two responsibilities are quite unrelated and the factory responsibility essentially boils down to the following method that is only ever invoked within WorkspaceImpl.getObservationManager():

public ObservationManagerImpl createObservationManager(SessionImpl session, ItemManager itemMgr)

{ return new ObservationManagerImpl(this, session, itemMgr); }

To simplify the design I'd inline this method and rename ObservationManagerFactory to ObservationDispatcher to better reflect the one remaining responsibility.