[JCR-559] AbstractQueryTest.hasDescriptor performing incorrect check

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: test
• Assignee: Unassigned
• Reporter: Melissa Stopponi
• Created: 01/Sep/06 23:08
• Updated: 12/Dec/06 13:09
• Resolved: 01/Dec/06 08:31

Description

The following method in AbstractQueryTest is incorrect. Accoring to the spec (section 6.1.1.1), if an option is not supported it should return "false". This method in the TCK instead assumes that "null" will be returned, and as a result does not throw an NotExecutableException.

protected boolean hasDescriptor(String descriptor)

{ return superuser.getRepository().getDescriptor(descriptor) != null; }

It should instead be:

protected boolean hasDescriptor(String descriptor)

{ return superuser.getRepository().getDescriptor(descriptor).equals("true"); }

This TCK bug causes the following (5) testcases to fail:

XPathPosIndexTest.testDocOrderIndexedNotation()

XPathDocOrderTest.testDocOrderFirstFunction()
XPathDocOrderTest.testDocOrderLastFunction()
XPathDocOrderTest.testDocOrderPositionFunction()
XPathDocOrderTest.testDocOrderPositionIndex()

Issue Links

• duplicates: JCR-481 Checks for optional features in test cases are wrong