[JCR-4213] It is useful to return an error code with DataStoreException when a record is not found

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Later
• Component/s: jackrabbit-data
• Assignee: Vikas Saurabh
• Reporter: Vikas Saurabh
• Created: 13/Nov/17 19:27
• Updated: 18/Dec/19 12:31
• Resolved: 14/Nov/17 10:57

Description

To help with cases like OAK-6935, it would be useful if DataStoreException, on best effort basis, provides and error code too.

An example stack that OAK-6935 logs currently looks like:

.... org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl Exception occurred while attempting to delete blob df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f#4694
org.apache.jackrabbit.core.data.DataStoreException: Record df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f does not exist
	at org.apache.jackrabbit.core.data.AbstractDataStore.getRecord(AbstractDataStore.java:58)
	at org.apache.jackrabbit.oak.plugins.blob.datastore.OakFileDataStore.getRecordForId(OakFileDataStore.java:259)
	at org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getRecordForId(DataStoreBlobStore.java:519)
	at org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.countDeleteChunks(DataStoreBlobStore.java:425)
	at org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl.purgeBlobsDeleted(ActiveDeletedBlobCollectorFactory.java:224)
	at org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService.lambda$initializeActiveBlobCollector$0(LuceneIndexProviderService.java:760)
...
...

/cc amjain

Issue Links

• is related to: OAK-6935 Active deletion logs warn messages when it tries to delete blobs already purged by DSGC