[JCR-3942] Content-Length header field may be set twice

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.11.3, 2.13.0
• Fix Version/s: 2.14.9, 2.20.1, 2.22, 2.21.1, 2.18.6, 2.16.7
• Component/s: jackrabbit-jcr-server
• Labels: cand easyfix patch performance
• Environment: Windows 10 64Bit, Java build 1.8.0_66-b17
• Flags: Patch
• Assignee: Julian Reschke
• Reporter: André Dörscheln
• Created: 11/Jan/16 20:49
• Updated: 03/May/21 06:04
• Resolved: 04/May/20 14:46

Description

In ExportContextImpl.java, in line 179, the variable hasContentLength is set, when the current header-field ist "Content-Length". This variable is used some lines below to check, if the header has already been written out.

The Problem: When "Content-Length" is not the last field of the header, the assignment is useless, because it gets overwritten in the next iteration and the header is set one time more, than it should be.

Patch would be to add an if-condition:

Patch

if (!hasContentLength) 
    hasContentLength = DavConstants.HEADER_CONTENT_LENGTH.equals(name);