[JCR-3940] Memory leak when calling RepositoryService.obtain with null workspaceName

• Type: Bug
• Status: Patch Available
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 2.10.1, 2.11.3
• Component/s: jackrabbit-spi2dav
• Labels: easyfix patch
• Flags: Patch
• Assignee: Unassigned
• Reporter: Oleksandr Kuzmenko
• Created: 19/Dec/15 16:43
• Updated: 19/Dec/15 16:46

Description

The bug is located in method org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(CredentialsWrapper credentials, String workspaceName)

When passing null to workspaceName parameter that's what happens:

1. an instance of org.apache.jackrabbit.spi2dav.SessionInfoImpl created with null workspace name (line 770)
2. HttpClient created for this sessionInfo and stored to cache with sessionInfo as a key (line 779)
3. a new sessionInfo created with effective workspace name (line 793)
4. sessionInfo with effective workspace name returned to caller

The problem is that HttpClient created on step 2 will not be removed from cache on call to org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.dispose(SessionInfo) because it is linked to sessionInfo created on step 1 which is thrown away on step 3.

The proposed solution is pretty easy - just call removeClient(SessionInfo) before creating new sessionInfo on step 3.
See attached patch.