[JCR-3629] [jcr2spi]RepositoryException lost in org.apache.jackrabbit.jcr2spi.ItemManagerImpl while querying on remote nodes exposed by jackrabbit-spi

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.3
• Fix Version/s: 0.9, 2.7.1
• Component/s: jackrabbit-jcr2spi
• Assignee: Chetan Mehrotra
• Reporter: Abhinav Atul
• Created: 24/Jul/13 14:45
• Updated: 26/Aug/19 08:47
• Resolved: 26/Jul/13 04:46

Description

RepositoryException lost in ItemManagerImpl#nodeExists, ItemManagerImpl#itemExists(HierarchyEntry), ItemManagerImpl#propertyExists, ItemManagerImpl#itemExists(ItemState)

/**

• @see ItemManager#nodeExists(Path)
  */
  public boolean nodeExists(Path path)
  Unknown macro: { try { // session-sanity & permissions are checked upon itemExists(ItemState) NodeState nodeState = hierMgr.getNodeState(path); return itemExists(nodeState); } catch (PathNotFoundException pnfe) { return false; } catch (ItemNotFoundException infe) { return false; } catch (RepositoryException re) { return false; } }

The catch block for RepositoryException should probably wrap the exception as a RuntimeException as it might happen for unknown reason.
Changing this might break backward compatibility.

The issue was detected when trying to implement a synchronization service with a content repository exposed by a jackrabbit-spi implementation. If the content repository becomes non-responsive while checking whether a node exists or not, the RepositoryException is lost in ItemManager#nodeExists resulting in deletion of the local node corresponding to the remote node.