[JCR-3556] IndexingConfigurationImpl.getAggregateRules() should return null in case no aggregate rules are configured

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.13, 2.4.3, 2.5.3, 2.6
• Fix Version/s: 2.7
• Component/s: indexing, jackrabbit-core
• Assignee: Unassigned
• Reporter: Sergiy Shyrkov
• Created: 03/Apr/13 13:31
• Updated: 10/May/13 19:44
• Resolved: 03/Apr/13 14:06

Description

Right now the IndexingConfigurationImpl.getAggregateRules() returns an empty array in case no rules are configured as this it is initialized in the init() method as follows:

aggregateRules = idxAggregates.toArray(new AggregateRule[idxAggregates.size()]);

so it is never null, but rather an empty array.

This causes small overhead when updating index in case no aggregate rules are configured (in our case on the version store).

The org.apache.jackrabbit.core.query.lucene.SearchIndex.retrieveAggregateRoot(Set<NodeId>, Map<NodeId, NodeState>) method opens the reader and searches for terms (_:AGGR_NODE_UUID) in any case.

Could we change the IndexingConfigurationImpl.init() to set aggregateRules to null when no aggregate rules are configured?