[JCR-3406] Journal doUnlock sometimes not called on repository shutdown

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.2
• Assignee: Thomas Mueller
• Reporter: Thomas Mueller
• Created: 08/Aug/12 10:17
• Updated: 23/Jan/13 08:29
• Resolved: 30/Aug/12 10:28

Description

When the repository is shut down, the method AbstractJournal.doUnlock(boolean successful) is sometimes not called. The method Journal.close is called, but when the journal implementation uses a reentrant lock it can't unlock because close is called from a different thread.

The reason for not calling doUnlock is that ClusterNode.stop() sets the status to "stopped", which causes all WorkspaceUpdateChannel methods to not work, including updateCommitted and updateCancelled. Therefore, it is possible that an operation is started but never completed nor cancelled.

To solve the issue, I found that it is enough to let updateCommitted and updateCancelled to complete, so that operations that are in progress can finish.