[JCR-3303] ClusterNode's stopDelay should default to something other zero

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.1
• Fix Version/s: 2.2.13, 2.4.2, 2.5
• Component/s: jackrabbit-core
• Assignee: Unassigned
• Reporter: Mete Atamel
• Created: 09/May/12 14:42
• Updated: 10/Jun/12 11:53
• Resolved: 09/May/12 15:57

Description

ClusterNode has a stopDelay that defaults to zero. This is problematic because it's used in joining syncThread. SyncThread is supposed to be a daemon thread which means it's not supposed to block JVM shutdown. However, by joining syncThread with a default stopDelay of zero, ClusterNode can potentially wait for syncThread to finish its job forever. This effectively makes syncThread a non-daemon thread and that can definitely make ClusterNode#stop block forever if syncThread never finishes.

Instead of defaulting to zero, I think it'd be better if stopDelay defaulted to something more reasonable like 2 * syncDelay. There's no need to make ClusterNode block forever for sync in any case.