[JCR-3291] Stack overflow in multi-session test with moves

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.2.12, 2.4.2, 2.5
• Component/s: jackrabbit-core
• Assignee: Bart van der Schans
• Reporter: Frank van Lankvelt
• Created: 14/Apr/12 12:06
• Updated: 09/Jul/13 08:21
• Resolved: 18/Apr/12 13:39

Description

When two sessions move nodes in incompatible ways (see test), the hierarchy manager can get into an infinite recursion when building paths.

Setup: nodes /a/aa & /b.

// results in /b/a/aa
session1.move(testRootPath + "/a", testRootPath + "/b/a");
// results in aa/b/aa/b/aa/b/aa/etc.
session2.move(testRootPath + "/b", testRootPath + "/a/aa/b");
session1.save();
session2.save();

The problem arises when the hierarchy manager uses a mix of transient states and unmodified states managed by the local item state manager.
When session 1 is saved, the state change of node a is dispatched to session 2. Node "a" is not changed in session 2, so it's new shared state will be used as-is.
It will have parent "b" according to the hierarchy manager in session 2.

The proposed solution is to keep track of the nodes that have been used in building up the path. This has the downside that building up paths becomes more expensive.
I haven't done any performance measurements yet on the impact of the change. If performance is an issue, perhaps the implementation can be limited to the case that the consistencyCheckEnabled flag is set.

Issue Links

• breaks: JCR-3619 After a move operation all ancestors of the destination path are modified