Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.1
    • Component/s: None
    • Labels:
      None

      Description

      Currently the consistency checker loads in a batch of node ids and for each node id fetches the corresponding bundle, its child bundles, and parent bundle separately. This makes the consistency checker perform less than optimal and may take hours (days?) to complete for large repositories.

      I've been able to make the checker execute about 20 times faster on my local machine by loading in batches of node prop bundles at once. For 17000 nodes in the workspace the current implementation ran for about 23 seconds whereas with the enhancements I made it finished in 1.2 seconds.

      Now the problem lies in the fact that loading in node prop bundles in batches may require a lot of memory. And it is not very predictable how much per batch size because the sizes of the individual bundles are unpredictable.

      Also the node prop bundle contains much more information than is needed for a consistency check.

      What would be ideal in this situation is to introduce a new type - call it NodeInfo - that contains only the structural information the checker needs to do its work. Meaning the node id, the parent id and the child ids. In order to allow for a possible future referential integrity check perhaps also its reference type propeties.

      The IterablePersistenceManager interface would then get an additional method:
      Map<NodeId, NodeInfo> getAllNodeInfos();

      If this is an acceptable proposal I would like to work on this and contribute a patch.

        Activity

        Unico Hommes created issue -
        Unico Hommes made changes -
        Field Original Value New Value
        Attachment checkerperformance.patch [ 12519946 ]
        Unico Hommes made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.6 [ 12319480 ]
        Resolution Fixed [ 1 ]
        Jukka Zitting made changes -
        Fix Version/s 2.5.1 [ 12321651 ]
        Fix Version/s 2.6 [ 12319480 ]
        Alex Parvulescu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Unico Hommes
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development