Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.11, 2.4
    • Fix Version/s: 2.2.12, 2.4.1, 2.5
    • Component/s: jackrabbit-core
    • Labels:
      None

      Description

      To assist in analyzing the bottleneck it would be good if it was easy to change the max size, currently hard-wired to 5000. Suggest to be pragmatic and do that through a system property.

        Activity

        Julian Reschke created issue -
        Julian Reschke made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Julian Reschke committed 1298428 (1 file)
        Hide
        angela added a comment -

        while i agree that it was useful for problem analysis, i somehow dislike the idea of having the size configurable with the acprovider config.
        the main reason is that i wouldn't want to be stuck with that implementation which imo has some fundamental drawbacks (e.g. perm eval
        only calculated on access).

        using a system property for analysis was fine for me if it was not part of an official release but only some sort of analysis-patch that
        is used temporarily.

        Show
        angela added a comment - while i agree that it was useful for problem analysis, i somehow dislike the idea of having the size configurable with the acprovider config. the main reason is that i wouldn't want to be stuck with that implementation which imo has some fundamental drawbacks (e.g. perm eval only calculated on access). using a system property for analysis was fine for me if it was not part of an official release but only some sort of analysis-patch that is used temporarily.
        Julian Reschke committed 1298435 (2 files)
        Reviews: none

        JCR-3254: make max size of CachingEntryCollector's cache configurable (backported to 2.2)

        Julian Reschke committed 1298436 (2 files)
        Reviews: none

        JCR-3254: make max size of CachingEntryCollector's cache configurable (backported to 2.4)

        Julian Reschke made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Julian Reschke added a comment -

        I think once we understand the problem fully, and have a fix we can just nuke the system property. So it's really temporary.

        Show
        Julian Reschke added a comment - I think once we understand the problem fully, and have a fix we can just nuke the system property. So it's really temporary.
        Alex Parvulescu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jukka Zitting made changes -
        Fix Version/s 2.5 [ 12319280 ]
        Fix Version/s 2.6 [ 12319480 ]
        Hide
        Jan Haderka added a comment -

        Could you shed some light on "the problem" and it's symptoms? Or at least link the post in userlist related to this.
        Thx.

        Show
        Jan Haderka added a comment - Could you shed some light on "the problem" and it's symptoms? Or at least link the post in userlist related to this. Thx.
        Hide
        Julian Reschke added a comment -

        Jan: see the parent issue JCR-2950

        Show
        Julian Reschke added a comment - Jan: see the parent issue JCR-2950
        Hide
        Jan Haderka added a comment -

        Oops. Missed the fact it was subtask. Thx.

        Show
        Jan Haderka added a comment - Oops. Missed the fact it was subtask. Thx.

          People

          • Assignee:
            Julian Reschke
            Reporter:
            Julian Reschke
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development