Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.6
    • Labels:
      None
    1. JCR-3172.diff
      14 kB
      Julian Reschke

      Activity

      Hide
      Stefan Guggisberg added a comment -

      we'll probably have to add a PERSIST event at the end of
      o.a.jackrabbit.core.observation.EventStateCollection#createEventStates

      Show
      Stefan Guggisberg added a comment - we'll probably have to add a PERSIST event at the end of o.a.jackrabbit.core.observation.EventStateCollection#createEventStates
      Hide
      Julian Reschke added a comment -

      Wouldn't be EventJournalImpl the obvious place? It iterates through EventBundles and could add PERSIST each time the end of a bundle was reached..

      Show
      Julian Reschke added a comment - Wouldn't be EventJournalImpl the obvious place? It iterates through EventBundles and could add PERSIST each time the end of a bundle was reached..
      Hide
      Stefan Guggisberg added a comment -

      > Wouldn't be EventJournalImpl the obvious place? It iterates through EventBundles and could add PERSIST each time the end of a bundle was reached..

      yes, perhaps. i am not familiar with the details of EventJournalImpl and what the criteria of event bundling are.

      anyway, EventStateCollection#createEventStates is probably the wrong place since PERSIST events should only appear in the event journal.

      Show
      Stefan Guggisberg added a comment - > Wouldn't be EventJournalImpl the obvious place? It iterates through EventBundles and could add PERSIST each time the end of a bundle was reached.. yes, perhaps. i am not familiar with the details of EventJournalImpl and what the criteria of event bundling are. anyway, EventStateCollection#createEventStates is probably the wrong place since PERSIST events should only appear in the event journal.
      Hide
      Julian Reschke added a comment -

      Patch, work-in-progress.

      Note that the introduction of PERSIST events may cause trouble for existing EventJournal consumers, due to some method on Event now potentially returning null.

      Show
      Julian Reschke added a comment - Patch, work-in-progress. Note that the introduction of PERSIST events may cause trouble for existing EventJournal consumers, due to some method on Event now potentially returning null.
      Hide
      Julian Reschke added a comment -

      Proposed patch, including fixes for spi-commons and spi2jcr

      Show
      Julian Reschke added a comment - Proposed patch, including fixes for spi-commons and spi2jcr
      Hide
      Julian Reschke added a comment -

      Added <http://java.net/jira/browse/JSR_333-44> on how to filter PERSIST events.

      Show
      Julian Reschke added a comment - Added < http://java.net/jira/browse/JSR_333-44 > on how to filter PERSIST events.
      Hide
      Julian Reschke added a comment -

      "final" patch. "final", as we apparently have zero test coverage, which I'll try to take care of next.

      Show
      Julian Reschke added a comment - "final" patch. "final", as we apparently have zero test coverage, which I'll try to take care of next.
      Hide
      Stefan Guggisberg added a comment -

      +1 for the patch (JCR-3172.diff)

      Show
      Stefan Guggisberg added a comment - +1 for the patch ( JCR-3172 .diff)

        People

        • Assignee:
          Julian Reschke
          Reporter:
          Julian Reschke
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development