Jackrabbit Content Repository
  1. Jackrabbit Content Repository
  2. JCR-3087

InternalVersionHistoryImpl might throw RuntimeException

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Not a Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: jackrabbit-core
    • Labels:
      None

      Description

      InternalVersionHistoryImpl.getVersion currently wraps RepositoryExceptions that occur on "reload()" into a RuntimeException. This may cause the RepositoryChecker to abort when attempting to fix a repository, defeating the point of running it.

      I see two options:

      1) Add "throws RepositoryException" to the signature so no wrapping is needed; this will cause similar changes in various interfaces and implementations; but it appears to be straightforward.

      2) Modify the RepositoryChecker to catch RuntimeExceptions as well.

        Issue Links

          Activity

          Jukka Zitting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Julian Reschke made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Not A Problem [ 8 ]
          Hide
          Julian Reschke added a comment -

          It appears there's no problem here as RuntimeException indeed is a subclass of Exception and thus gets catched in RepositoryChecker.checkVersionHistory().

          Show
          Julian Reschke added a comment - It appears there's no problem here as RuntimeException indeed is a subclass of Exception and thus gets catched in RepositoryChecker.checkVersionHistory().
          Julian Reschke made changes -
          Assignee Julian Reschke [ reschke ]
          Julian Reschke made changes -
          Field Original Value New Value
          Link This issue is related to JCR-3017 [ JCR-3017 ]
          Julian Reschke created issue -

            People

            • Assignee:
              Julian Reschke
              Reporter:
              Julian Reschke
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development