[JCR-2891] VersionManagerImplRestore internalRestoreFrozen method has identity versus equals bug

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.2
• Fix Version/s: 2.1.5, 2.2.5
• Component/s: jackrabbit-core
• Environment: Exists in 2.2.4 version of code base (as well as 2.3)
• Assignee: Stefan Guggisberg
• Reporter: Matt Goodwin
• Created: 15/Feb/11 18:54
• Updated: 14/Apr/11 14:33
• Resolved: 17/Feb/11 10:05

Description

In method protected void internalRestoreFrozen(NodeStateEx state,
InternalFrozenNode freeze,
VersionSelector vsel,
Set<InternalVersion> restored,
boolean removeExisting,
boolean copy)
in the VersionManagerImplRestore class line 557 the code performs an == instead of calling the NodeId.equals() method. We ran into problems with the code that executes below this (trying to restore a folder node throws an ItemExistsException since same sibling not allowed on folder nodes)

Issue Links

• is duplicated by: JCR-2912 VersionManager.restore fails with ItemExitsException although the removeExisting parameter is set to true